fix(deps): restore @vue/eslint-config-typescript dropped during merge#151
Merged
Merged
Conversation
PR #144's merge resolution accidentally dropped this devDependency along with @semantic-release/git. @nextcloud/eslint-config@8.4.2's index.js extends from @vue/eslint-config-typescript/recommended at runtime, so without it npm run lint fails with 'ESLint couldn't find the config' — blocking the release workflow. Adding it back to devDependencies restores both local and CI lint.
Contributor
|
🎉 This PR is included in version 1.0.0-beta.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #144's merge conflict resolution accidentally dropped
@vue/eslint-config-typescriptfromdevDependencies(it lived in the same conflict block as@semantic-release/git, which was intentionally removed).@nextcloud/eslint-config@8.4.2/index.jsextends from@vue/eslint-config-typescript/recommendedat runtime — without the package installed,npm run lintfails with:That blocks the release workflow on every push to beta.
Fix
Re-add
@vue/eslint-config-typescript@^12.0.0todevDependencies. Lockfile regenerated vianpm install --legacy-peer-deps. Localnpm run lintandnpm testpass (0 errors, 646/646 tests).