fix(deps): pin apexcharts as direct dep#155
Merged
Merged
Conversation
…s it PR #149 added `--legacy-peer-deps` to `npm ci` to work around peer-dep resolution differences between npm 10 and npm 11. That flag skips ALL peer-dep auto-installs, which means `apexcharts` (a peer dep of `vue-apexcharts`) is now missing at build time: Could not load /home/runner/.../node_modules/apexcharts/dist/apexcharts.min.js: ENOENT: no such file or directory `vue-apexcharts`'s peer is `apexcharts >=4.0.0`. Adding it as a direct dep with `^4.0.0` constraint: - Restores build under `--legacy-peer-deps` - Aligns with the project memory rule ("Shared deps via nextcloud-vue") that lists apexcharts as something nextcloud-vue is supposed to provide Verified locally: - `npm ci --legacy-peer-deps`: clean - `npm run build`: clean (only the pre-existing codemirror externals warning, which is bundled at runtime by the consumer) - `npm test`: 646/646 green
PR #149 added `--legacy-peer-deps` to release.yml's npm ci to skip the npm 11 peer-dep ERESOLVE failure on @vue/eslint-config-typescript. Code Quality (which gates PR merges) was missed and still uses bare `npm ci`, so any new PR fails Frontend Quality with the same conflict the release flow already works around. Bring code-quality.yml in line.
rubenvdlinde
requested review from
Rem-Dam,
WilcoLouwerse,
bbrands02 and
rjzondervan
as code owners
PR #144 added the `liveUpdatesPlugin` export to src/index.js but did not include the corresponding doc page that scripts/check-docs.js requires for every public store-plugin export. CI's docs-coverage gate on every PR is now blocked on this missing page. The doc follows the same shape as the other store-plugin docs (audit-trails.md, lifecycle.md, etc.): usage example, plugin options table, contributed state/getters/actions, cleanup notes (with an explicit Vue 2.7 Options API caveat), in-flight dedup explanation, and a transport section covering the @nextcloud/notify_push → polling fallback ladder. Verified locally with `npm run check:docs` — all 110 exports documented, all accuracy checks pass.
Contributor
|
🎉 This PR is included in version 1.0.0-beta.5 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #149's `--legacy-peer-deps` skips `apexcharts` (a peer of `vue-apexcharts`), breaking the build:
```
Could not load apexcharts.min.js: ENOENT: no such file or directory
```
Adding `apexcharts: ^4.0.0` (matching `vue-apexcharts`'s peer constraint of `>=4.0.0`) as a direct dep restores the install under `--legacy-peer-deps`. Also aligns with project memory ("Shared deps via nextcloud-vue") that lists apexcharts as a dep this lib should provide.
Verified locally with the same env CI uses: