Skip to content

Resources/template/lib/Service/SettingsService.php uses stale 2-arg importFromApp signature #47

@rubenvdlinde

Description

@rubenvdlinde

Problem

The scaffolding template at openbuilt/lib/Resources/template/lib/Service/SettingsService.php:143 calls ConfigurationService::importFromApp(appId: ..., force: ...) with the old 2-arg signature. The current OpenRegister method requires ($appId, array $data, string $version, bool $force).

Net effect: every fresh app scaffolded from this template will throw ArgumentCountError at install time, just like decidesk #196 (fixed in #199) and shillinq (issue filed).

Fix

Replace the 2-arg call with the JSON-load + 4-arg pattern that the planix/scholiq/decidesk app code already uses — load lib/Settings/{appId}_register.json from disk, extract info.version, pass 4 args. See decidesk PR #199 for the canonical pattern.

Scope

Template-only change. After merge, also bump the scaffolding scripts so new apps land with the correct signature.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions