chore(brand): preset 2.10 + auto-derived hero + smaller app-icon glyph#763
chore(brand): preset 2.10 + auto-derived hero + smaller app-icon glyph#763rubenvdlinde wants to merge 2 commits into
Conversation
img/app-store.svg — shrink inner glyph (~40% of hex height instead of ~60%), better breathing room around the cobalt hex. This app has no Docusaurus docs site, so the preset bump + DetailHero auto-derivation changes from design-system 2.10.0 don't apply here.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ❌ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 148/148 | |||
| npm | ❌ | ❌ 1/573 denied | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
❌ Denied npm licenses
| Package | Version | License |
|---|---|---|
| @fortawesome/free-solid-svg-icons | 6.7.2 | (CC-BY-4.0 AND MIT) |
Quality workflow — 2026-05-13 10:36 UTC
Download the full PDF report from the workflow artifacts.
| @@ -1,6 +1,6 @@ | |||
| <svg xmlns="http://www.w3.org/2000/svg" viewBox="0 0 512 512"> | |||
| <polygon points="256,26 455.19,141 455.19,371 256,486 56.81,371 56.81,141" fill="#4376FC"/> | |||
There was a problem hiding this comment.
🟡 CONCERN: Overlapping edit with PR #762 — merge order matters
Same issue as procest #447/#446: PR #762 changes the polygon fill from #4376FC to #21468B, while PR #763 changes the glyph transform/scale on the same file. The two branches diverged from a common base. Whichever merges second must have rebased on top of the first; otherwise the second merge will silently revert the first PR's change. Confirm that before merging #763, it is rebased on a commit that already includes the #762 color change (or merge #762 first and then rebase #763), and validate the final SVG contains both fill="#21468B" and translate(164,164) scale(7.67).
Quality Report — ConductionNL/openconnector @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 148/148 | |||
| npm | ✅ | ✅ 674/674 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-19 04:04 UTC
Download the full PDF report from the workflow artifacts.
|
Closing this PR — The other strand of the PR (preset bump itself) is overtaken; the SVG glyph adjustment is the carry-forward value. Thanks for the original. |
2 participants
Aligns this app with the design-system 2.10.0 release: preset bumped, hard-coded
<DetailHero/>status/versionprops dropped (the new preset auto-derives fromappinfo/info.xml+ SemVer), inner glyph inimg/app-store.svgshrunk to ~40% of the hex height. No code or behaviour changes beyond the brand chrome.