Fix the constructors of a job and three services still using a removed class#1332
Merged
Conversation
bbrands02
approved these changes
Apr 23, 2026
Contributor
There was a problem hiding this comment.
Nette, minimale fix — de bug klopt: ObjectEntityMapper is verwijderd en MagicMapper is de juiste vervanger (zo ook geregistreerd in Application.php). De find()/update()-calls in EdepotTransferService blijven werken (defaults voor register/schema worden intern geresolved).
Twee kleine aandachtspunten:
- Dode injectie: in
TransferCheckJobenTransferListServicewordt$this->objectMappernergens aangeroepen. Is pre-existing, maar dit is een goed moment om de ongebruikte parameter meteen te schrappen i.p.v. alleen het type om te zetten. - CI: PHP-quality (phpstan/psalm/phpmd/phpcs/lint) is groen, maar Newman integration + PHPUnit staan nog pending/failed. Even afwachten tot alles groen is voor merge. (mag je negeren als dit nog steeds aan 'main' ligt)
WilcoLouwerse
approved these changes
Apr 23, 2026
Contributor
Quality Report — ConductionNL/openregister @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 147/147 | |||
| npm | ✅ | ✅ 599/599 | |||
| PHPUnit | ❌ | ||||
| Newman | ❌ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-04-23 11:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.