finished register dialog#4
Merged
Merged
Conversation
remko48
approved these changes
Sep 25, 2024
rubenvdlinde
pushed a commit
that referenced
this pull request
Jul 30, 2025
…modal finished register dialog
4 tasks
5 tasks
WilcoLouwerse
added a commit
that referenced
this pull request
May 7, 2026
Address PR #1436 review feedback: - Replace `$data['share'] === 'true'` strict comparison with `$this->parseBool(value: $data['share'] ?? false)` in both `normalizeSingleFile` and `normalizeMultipleFiles`. This matches what `create()` already does and accepts `1`, `yes`, `on`, and a real boolean `true` instead of silently returning false for any non-`'true'` literal. - Strengthen `testExtractUploadedFilesSingleFile` to assert the normalized shape (`share` is bool, `tags` is array) so a future refactor of `normalizeSingleFile` cannot silently re-introduce the original `TypeError: FileService::addFile(): Argument #4 ($share) must be of type bool, null given`. - Add `testExtractUploadedFilesShareParsing` data provider covering the truthy/falsy cases parseBool now accepts. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
3 tasks
rubenvdlinde
added a commit
that referenced
this pull request
May 11, 2026
Runtime CRUD on /api/schemas and /api/registers with cache invalidation and declarative-engine reload, so callers (especially OpenBuilt's schema editor in chain spec #4) can author schemas at runtime instead of shipping them as static JSON in lib/Settings/{app}_register.json. Plus two follow-ups from the bootstrap-openbuilt smoke test (2026-05-11, commit 3138e4c): - importFromApp auto-creates a Register from x-openregister.app + info.title + info.description for application-type configurations - ObjectService::searchObjectsBySlug helper resolves register/schema slugs to numeric IDs before delegating to searchObjects; existing searchObjects docblock updated to make the numeric-ID-only contract explicit 5 artifacts: - proposal.md (kind=mixed, chained to openbuilt-schema-editor) - specs/runtime-schema-api/spec.md (new capability) - specs/data-import-export/spec.md (delta for importFromApp behaviour) - design.md (5 decisions, migration plan) - tasks.md (8 task groups, 28 tasks) openspec validate --strict: passes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.