fix: Resolve remaining PHPCS violations in CI#937
Merged
rubenvdlinde merged 2 commits intodevelopmentfrom Mar 19, 2026
Merged
Conversation
- Add --warning-severity=0 to composer phpcs script to prevent warnings from causing non-zero exit code in CI (bash -e kills the process before the exit code handler runs) - Fix line-length warnings by extracting intermediate variables in DeleteObject, MagicTableHandler, and SaveObjects - Remove Squiz.PHP.DisallowInlineIf rule to allow ternary operators - Fix whitespace issues in phpcs.xml
Contributor
Quality Report
Summary
PHP Quality
Vue Quality
Security
License Compliance
composer dependencies (147 total)
npm dependencies (586 total)
PHPUnit TestsPHPUnit tests were not enabled for this run. Integration Tests (Newman)Newman integration tests were not enabled for this run. Generated automatically by the Quality workflow.
|
rjzondervan
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--warning-severity=0tocomposer phpcsscript to prevent line-length warnings (exit code 1) from causing CI failure underbash -eSquiz.PHP.DisallowInlineIfrule to allow ternary operators (needed after ElseExpression elimination)Root cause
The reusable CI workflow runs
composer phpcs; RC=$?underbash -e. When PHPCS returns exit code 1 (warnings only, no errors), bash immediately exits before theRC=$?line executes, so the warning-tolerance logic never runs.Test plan
lib/