feat(process-step-configuration): apply spec — validator + editor (partial)#381
Merged
Merged
Conversation
Manifest-first apply of openspec change `process-step-configuration`.
Schema:
- Bump workflowTemplate version 1.0.0 → 1.1.0 with additive
documentation of the per-step `config` sub-object
({sla, requiredFields, autoActions, escalationRule}).
No new top-level register schema.
Validator:
- Add pure-function StepConfigValidator (no DI, no I/O) implementing
the seven rules from design.md. Returns structured {path, code,
message} errors; never raw exception text.
Editor:
- Extend the existing StepConfigPanel.vue with a collapsible
"Geavanceerd" panel for sla / requiredFields / escalationRule.
- Pass `read-only` from WorkflowEditor.vue via a new `isPublished`
computed (template.isDraft === false), per REQ-PSC-7-002.
Deferred (host services not yet on development):
- T03 publish hook, T04/T05 status-transition-engine consumption,
T06 task creator, T09 bezwaar backfill, T10 spec flip.
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 407/407 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 3% (21 tests / 673 specs)
Quality workflow — 2026-05-11 11:57 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manifest-first apply of openspec change
process-step-configuration.workflowTemplatebumped 1.0.0 → 1.1.0 with additive documentation of the per-stepconfigsub-object ({sla, requiredFields, autoActions, escalationRule}). No new top-level register schema.lib/Service/StepConfigValidator.php— pure-function, no DI, no I/O. Implements the seven rules fromdesign.mdand returns structured{path, code, message}errors (never raw exception text).StepConfigPanel.vuewith a collapsible "Geavanceerd" panel for SLA / required fields / escalation rule. Read-only wired fromWorkflowEditor.vuevia newisPublishedcomputed (template.isDraft === false).Deferred (host services not on
developmentyet)WorkflowDefinitionService::publish()StatusTransitionServiceconsumption (implicitrequiredFieldsguard + step-level auto-action ordering)TaskCreatorService::createForStep()dueAt + escalationAt stampingBackfillBezwaarStepConfigrepair stepopenspec/specs/process-step-configuration/spec.mdtostatus: implementedThese all depend on services from sibling specs
workflow-definition-model(#347) andstatus-transition-engine(#352) that have not yet landed in this tree. The validator is ready; the wiring becomes a one-liner once those services exist.Validation
php -l lib/Service/StepConfigValidator.php— passjq -e .onprocest_register.jsonandbuild.json— passgetMessage()in returned errorscomposer check:strictand i18n deferred per STRICT watchdogTest plan
{value: 5, unit: businessDays}and confirm round-trip via store