feat(map-component): apply spec#388
Merged
Merged
Conversation
Add the shared MapComponent Vue wrapper around CnMapWidget plus the mapFormatters registry, and register MapComponent in customComponents so manifest pages MAY mount it by name. This is the manifest-first slice of openspec/changes/map-component (T01, T02). Consumer migrations (CaseMapTab T03, CaseMapWidget T04, PublicCaseView T05) remain owned by case-location, case-map-overview, and the public-case-page specs respectively — see builds/build.json deferred list for the trail.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 3% (21 tests / 673 specs)
Quality workflow — 2026-05-11 12:05 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Manifest-first slice of
openspec/changes/map-component(T01, T02):src/components/map/MapComponent.vue— thin Vue 2 wrapper aroundCnMapWidgetfrom@conduction/nextcloud-vue. Props:locations[],center,zoom,interactive,markerFormatter(string, registry lookup),tileLayer,clustering,height. Events:marker-click,viewport-change(debounced 200 ms),ready. Read-only mode (:interactive="false") switches container role toimgand disables every Leaflet interaction primitive.src/services/mapFormatters.js— formatter registry withcaseMarkerFormatter(status-driven NL Design palette via CSS variables) andlocationMarkerFormatter; polygons reduced to arithmetic-mean centroid markers (geometry types other than Point/Polygon are skipped).MapComponentinsrc/customComponents.jsso manifest pages MAY mount it by string name.builds/build.jsonwith the consumer migrations (T03-T05) deferred to their owning specs (case-location,case-map-overview, public case page).No PHP. No new routes. No manifest pages. No i18n bundle changes (per strict-watchdog scope).
Test plan
:interactive="false"and confirm containerrole="img"and zoom controls hidden.customComponents.MapComponentresolves at runtime.CnMapWidgetrequires@conduction/nextcloud-vue>= beta.30; current procest dependency is beta.29 — runtime smoke depends on the lib bump landing.