feat(case-map-overview): apply spec#389
Merged
Merged
Conversation
Convert the existing `/map` page from a hand-written `CaseMapView.vue` custom component to a manifest-driven `type: 'map'` page consuming `CnMapPage` from @conduction/nextcloud-vue beta.30 (ADR-008). Changes: - src/manifest.json: CaseMap page entry switched to `type: 'map'` with full config block — register/schema, geometryField, filter ids, marker.formatter, clustering (with status-priority order blocked > in_progress > open > closed), bboxQuery threshold (5k pins), pdok-brt tile layer, sidebar config, and inline emptyState (nl). - src/services/mapFormatters.js: new — exports `caseMarkerFormatter`, `statusColor`, `statusIcon`. Handles Point + Polygon centroid + null geometry. Uses NL Design System color tokens (var(--color-status-*), no hardcoded hex). - src/main.js: registers the mapFormatters registry on Vue.prototype and on the App props (mirrors customComponents pattern). - src/customComponents.js: drop the CaseMapView import + registration. - src/views/CaseMapView.vue: deleted (replaced by CnMapPage). - builds/build.json: record application; verification tasks deferred per strict watchdog (lint + jq only) and 5k-pin perf benchmark follows in a separate change.
9277fd8 to
3a1d425
Compare
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ❌ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ❌ | ||||
| stylelint | ❌ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Spec coverage: 3% (21 tests / 673 specs)
Quality workflow — 2026-05-11 12:09 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Applies the
case-map-overviewspec. Converts the existing/mappage from a hand-writtenCaseMapView.vue(type: 'custom') to a fully manifest-driventype: 'map'page that consumesCnMapPagefrom@conduction/nextcloud-vuebeta.30. The only Vue surface added is a tiny marker-formatter module.Manifest changes
src/manifest.json→CaseMappage:type: 'custom'→type: 'map'component: 'CaseMapView'configblock:register: 'procest',schema: 'case',geometryField: 'geometry'filters: ['status', 'caseType', 'assignee', 'deadlineRange']marker.formatter: 'caseMarkerFormatter'clustering: { enabled: true, disableAtZoom: 14, priority: ['blocked','in_progress','open','closed'] }bboxQuery: { threshold: 5000 }(viewport-bounded queries beyond 5k pins)tileLayer: 'pdok-brt'sidebar: { enabled: true, filtersOpen: true }emptyState(icon + nl title/body)Formatter registration
src/services/mapFormatters.jsexportscaseMarkerFormatter,statusColor,statusIcon.nullso the lib skips).var(--color-status-{info,warning,error}),var(--color-text-maxcontrast)) — no hardcoded hex.src/main.jsexposes the formatter registry asVue.prototype.$mapFormattersand onAppprops (mirrors the existingcustomComponentspattern).Cleanup
src/views/CaseMapView.vue(replaced byCnMapPage).CaseMapViewimport + registration fromsrc/customComponents.js.Constraints honoured
jqvalidation only.jq validation
Deferred (recorded in builds/build.json)
CnMapPage.Test plan
/mapafternpm run build— page renders viaCnMapPage, no console errors.geometry; status colours match palette./cases/:id.status = open) → only blue pins remain; viewport preserved.