test(e2e): write Playwright artifacts where the shared workflow uploads from#424
Merged
Merged
Conversation
…ds from quality.yml uploads the HTML report from server/apps/<app>/playwright-report and traces/screenshots from server/apps/<app>/test-results, but the config wrote them under tests/e2e/, so failure artifacts were never uploaded. Point outputDir at test-results/ and the html reporter at playwright-report/ (and keep traces on failure). Drop the stale committed test-results/ exploration dump and gitignore the new output dirs.
rubenvdlinde
requested review from
Rem-Dam,
SudoThijn,
WilcoLouwerse,
bbrands02,
remko48 and
rjzondervan
as code owners
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-12 17:12 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shared
quality.ymlworkflow uploads the Playwright HTML report fromserver/apps/<app>/playwright-report/and traces/screenshots fromserver/apps/<app>/test-results/, butplaywright.config.tswrote them undertests/e2e/— so on a failing E2E run nothing useful gets uploaded (theplaywright-tracesartifact only ever contained a stale checked-in exploration dump).outputDir→test-results/, html reporteroutputFolder→playwright-report/, junit →test-results/results.xml— matching the workflow's upload paths.trace: 'on-first-retry'→'retain-on-failure'so a trace is always kept when a test fails.test-results/exploration dump (comprehensive-results.md+screenshots/, dated Feb 2026, pre-manifest-migration) and gitignored the new output dirs.Needed so the remaining 2 failing E2E tests (Dashboard heading, New Case modal — both render fine locally) can actually be diagnosed from CI artifacts.