fix: route procest API calls through generateUrl() (work without mod_rewrite)#425
Merged
Merged
Conversation
…ut mod_rewrite Several frontend fetches hardcoded /apps/procest/api/... — fine behind Apache+rewrite, but in a bare 'php -S' env (incl. the CI E2E job) that path isn't routable and 404s. Most visibly: the settings store's /api/settings fetch fails in CI, so the dashboard widgets never get configured (all show 'Widget not available') and CnFormDialog opens with an empty form. Wrap the URLs in generateUrl() like the other API services already do: - store/modules/settings.js (/api/settings) - store/modules/zgwMapping.js (/api/zgw-mappings[...]) - views/settings/AdminRoot.vue (/api/settings/load) - views/voorstellen/VoorstelList.vue (/api/notifications/parafering-reminder)
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ✅ | ✅ 100/100 | |||
| npm | ✅ | ✅ 419/419 | |||
| PHPUnit | ✅ | ||||
| Newman | ⏭️ | ||||
| Playwright | ❌ |
Coverage: 0% (0/81 statements)
Spec coverage: 5% (21 tests / 456 specs)
Quality workflow — 2026-05-12 17:15 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several frontend
fetch()calls hardcode/apps/procest/api/.... That works behind Apache +mod_rewrite, but in a barephp -Senvironment (including the CI E2E job) those paths aren't routable and 404.Most visibly: the settings store's
/api/settingsfetch 404s in CI, so the dashboard widgets never get configured (all 11 render "Widget not available", and the dashboard header<h2>+ action buttons don't render), andCnFormDialogopens with an empty form on the Cases page. Confirmed from the Playwright trace (404 GET http://localhost:8080/apps/procest/api/settings).Fix: wrap the URLs in
generateUrl(), matching the other API services (aiApi.js,parafeerRouteApi.js, etc.):store/modules/settings.js—/api/settingsstore/modules/zgwMapping.js—/api/zgw-mappings[...]views/settings/AdminRoot.vue—/api/settings/loadviews/voorstellen/VoorstelList.vue—/api/notifications/parafering-reminderShould fix the 2 remaining E2E failures (
Dashboard › shows heading and action buttons,Cases page › new case modal has correct fields).