Skip to content

retrofit: reverse-spec mcp-integration (5 REQs / 1 file)#589

Merged
rubenvdlinde merged 1 commit into
developmentfrom
retrofit/reverse-spec-procest-mcp-integration-2026-05-24
May 25, 2026
Merged

retrofit: reverse-spec mcp-integration (5 REQs / 1 file)#589
rubenvdlinde merged 1 commit into
developmentfrom
retrofit/reverse-spec-procest-mcp-integration-2026-05-24

Conversation

@rubenvdlinde
Copy link
Copy Markdown
Contributor

Retrofit — Reverse-Spec

Describes observed behavior of lib/Mcp/ProcestToolProvider.php (21 methods) — procest's IMcpToolProvider implementation that the openregister AI orchestrator (ADR-034 / ADR-035) calls during an AI Chat Companion turn — as 5 new REQs.

Ghost change: retrofit-2026-05-24-mcp-integration (archived inline).

What this PR does

  • Drafts 5 REQs in openspec/specs/mcp-integration/spec.md with retrofit: true
  • Creates ghost change scaffold (proposal/design/tasks/specs delta)
  • Annotates 1 file with @spec ...tasks.md#task-1..5
  • Archives the change inline

Note: kept distinct from ai-assistance

ai-assistance covers the human-facing AI surface; mcp-integration covers the orchestrator-facing tool provider only.

Note: out-of-scope tools tracked elsewhere

startProcess, advanceStep, listMyTasks, getTaskDetails are tracked in procest#416 — this REQ set covers only the MVP listProcesses + getProcessDetails skeleton currently in code.

Review focus

  • REQ-004's "MUST NOT catch \Throwable" reflects the OWASP A01 / ADR-005 contract called out in the file's own docblock
  • REQ-005's standard error envelope vs throwing matches observed pattern

Source: openspec/coverage-report.md generated 2026-05-24 | Cluster: mcp-integration

Refs #565.

REQ-001 Implement IMcpToolProvider with stable app id and hardcoded tool catalogue,
REQ-002 listProcesses tool with bounded limit and optional status filter,
REQ-003 getProcessDetails tool returning case + history,
REQ-004 Per-object authorisation (assignee/role/admin) inside invokeTool,
REQ-005 Standard error envelopes and result-cap.

Ghost change: retrofit-2026-05-24-mcp-integration.

Refs #565.
@rubenvdlinde rubenvdlinde added openspec OpenSpec-driven change yolo Auto-merge when all phases pass retrofit reverse-spec labels May 24, 2026
@rubenvdlinde rubenvdlinde added the openspec OpenSpec-driven change label May 24, 2026
@rubenvdlinde rubenvdlinde added yolo Auto-merge when all phases pass retrofit reverse-spec labels May 24, 2026
@github-actions
Copy link
Copy Markdown
Contributor

Quality Report — ConductionNL/procest @ 0352a26

Check PHP Vue Security License Tests
lint
phpcs
phpmd
psalm
phpstan
phpmetrics
eslint
stylelint
composer
npm ✅ 426/426
PHPUnit ⏭️
Newman ⏭️
Playwright ⏭️

Quality workflow — 2026-05-24 21:57 UTC

Download the full PDF report from the workflow artifacts.

@rubenvdlinde rubenvdlinde merged commit 5d7fc54 into development May 25, 2026
15 of 24 checks passed
@rubenvdlinde rubenvdlinde deleted the retrofit/reverse-spec-procest-mcp-integration-2026-05-24 branch May 25, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

openspec OpenSpec-driven change retrofit reverse-spec yolo Auto-merge when all phases pass

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant