fix(ui): bump @nextcloud/vue to ^8.39.0 (nav corner sliver on NC<34)#609
Merged
Conversation
Contributor
Quality Report — ConductionNL/procest @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ❌ | ||||
| phpcs | ❌ | ||||
| phpmd | ❌ | ||||
| psalm | ❌ | ||||
| phpstan | ❌ | ||||
| phpmetrics | ❌ | ||||
| eslint | ✅ | ||||
| stylelint | ✅ | ||||
| composer | ❌ | ❌ | |||
| npm | ✅ | ✅ 327/327 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-25 21:54 UTC
Download the full PDF report from the workflow artifacts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bumps
@nextcloud/vuefrom^8.16.0to^8.39.0.Why
@nextcloud/vueversions before 8.39.0 unconditionally render the Nextcloud 34 rounded.app-contentlayout. On Nextcloud < 34 the rounded white corner pokes past the square.app-navigation, producing a visible white sliver near the navigation toggle.Version 8.39.0 adds an
isLegacy34guard (NC major < 34) that restores the square layout on older Nextcloud versions, eliminating the sliver.Changes
@nextcloud/vuedependency pin to^8.39.0.package-lock.jsonaccordingly (resolves to 8.39.0).The JS bundle (
js/) is gitignored, so the only committed changes arepackage.json+package-lock.json.Part of a fleet-wide sweep.