chore: sync canonical root configs + mechanical phpmd cleanup#300
Merged
Conversation
Phase 2 fleet rollout of the root-config consolidation. Drops per-app phpcs/phpmd/psalm/phpstan extensions in favour of the canonical from nextcloud-app-template, then cleans the mechanical phpmd violations unmasked by the sync. Config changes: - phpcs.xml: sync canonical, restore Shillinq description. - phpmd.xml: byte-canonical, restore Shillinq ruleset name. - psalm.xml: sync canonical. - phpstan.neon: sync canonical (includes phpstan-baseline.neon). - phpstan-baseline.neon: NEW. 1 tracked phpstan error, see #299. - phpcs-custom-sniffs/.../{SpecTagSniff,NoLegacyServerAccessorsSniff}.php: copied from canonical so the synced phpcs.xml can reference them. Source: 2 ElseExpression in InitializeSettings.php refactored to a two-if pattern (preserves behavior, drops the else keyword). Quality gates after sync: - phpcs: 0 violations. - psalm: 0 errors. - phpstan: 0 unmatched (1 baselined per #299). - phpmd: 4 architectural violations remain — see #299.
Contributor
Quality Report — ConductionNL/shillinq @
|
| Check | PHP | Vue | Security | License | Tests |
|---|---|---|---|---|---|
| lint | ✅ | ||||
| phpcs | ✅ | ||||
| phpmd | ✅ | ||||
| psalm | ✅ | ||||
| phpstan | ✅ | ||||
| phpmetrics | ✅ | ||||
| eslint | ✅ | ||||
| stylelint | ❌ | ||||
| composer | ❌ | ✅ 100/100 | |||
| npm | ✅ | ✅ 422/422 | |||
| PHPUnit | ⏭️ | ||||
| Newman | ⏭️ | ||||
| Playwright | ⏭️ |
Quality workflow — 2026-05-21 20:21 UTC
Download the full PDF report from the workflow artifacts.
This was referenced May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 2 fleet rollout of the root-config consolidation. Replaces per-app phpcs/phpmd/psalm/phpstan extensions with the canonical from
nextcloud-app-template.Lint-debt tracking: #299.
Quality gates
phpmd has no native baseline support so CI stays red until #299 closes. Agreed-upon tracked-debt pattern.
Source changes
lib/Repair/InitializeSettings.phprefactored to a two-if pattern (preserves behaviour).@psalm-suppress/@phpstan-ignore— N/A, only the baseline file.Test plan