Skip to content

OPS-420: Classify connector init error as Warn#42

Merged
johnallers merged 1 commit into
mainfrom
OPS-420/classify-connector-init-error
Mar 17, 2026
Merged

OPS-420: Classify connector init error as Warn#42
johnallers merged 1 commit into
mainfrom
OPS-420/classify-connector-init-error

Conversation

@arreyder
Copy link
Copy Markdown
Contributor

Summary

  • Change connector creation error log from l.Error to l.Warn
  • Connector init failures are typically config/auth errors (invalid OAuth credentials, bad URL), not server errors

Test plan

  • go build ./... passes

🤖 Generated with Claude Code

Connector creation failures are typically config/auth errors (invalid
client credentials, bad URL), not server errors. Log at Warn to
reduce ERROR noise.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@arreyder arreyder requested a review from a team March 13, 2026 23:14
@linear
Copy link
Copy Markdown

linear Bot commented Mar 13, 2026

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Mar 13, 2026

Claude finished @arreyder's task in 37s —— View job


PR Review

  • Gather context and read changed files
  • Review PR changes
  • Post review feedback

Change: pkg/connector/connector.go:182l.Errorl.Warn

Verdict: Looks good 👍

This is a clean, well-scoped change. The rationale is sound — connector initialization failures in NewConnector are almost always caused by user-side configuration or authentication issues (invalid OAuth credentials, bad hostname, etc.), not internal server errors. Downgrading from Error to Warn is appropriate because:

  1. Error is still propagated — the function still returns the error (return nil, nil, err), so callers handle it properly. The log level change only affects observability classification, not control flow.
  2. Reduces noise — in containerized deployments, Error-level logs often trigger alerts. Config/auth failures are expected operational states that operators should investigate, but they aren't bugs or service failures warranting Error severity.
  3. Consistent with the OPS-420 initiative — this aligns with the broader error classification sweep across connector repos.

No issues found. No suggestions.

@johnallers johnallers merged commit 670ee32 into main Mar 17, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants