[BB-1128] Add uhttp client

[aldevv]

Description

• Bug fix
• New feature

Useful links:

• Baton SDK coding guidelines
• New contributor guide

[cursor]

Bug: LogBody Function Causes Panics and Data Loss

The logBody function reads the HTTP response body for logging. This introduces two issues: it does not check if response.Body is nil, which can cause a panic; and it consumes the body, making it unavailable for subsequent reads by other components (e.g., client.go, uhttp framework) that expect to process it.

pkg/onprem/helpers.go#L12-L25

baton-gitlab/pkg/onprem/helpers.go

Lines 12 to 25 in 10fa8a8

	func logBody(ctx context.Context, response *http.Response) {
	if response == nil {
	return
	}
	l := ctxzap.Extract(ctx)
	body := make([]byte, 10000)
	n, err := response.Body.Read(body)
	if err != nil {
	l.Error("error reading response body", zap.Error(err))
	return
	}
	l.Info("response body: ", zap.String("body", string(body[:n])))
	}

Fix in Cursor • Fix in Web

---

Bug: API Error Masked as Success

The ListExternalGroupMembers function incorrectly returns a nil error and potentially invalid users data when the GitLab API responds with a 403 Forbidden status code. This misrepresents an API error as a successful operation, leading to consumers receiving corrupted or incomplete data.

pkg/connector/gitlab/groups_endpoints.go#L59-L76

baton-gitlab/pkg/connector/gitlab/groups_endpoints.go

Lines 59 to 76 in 10fa8a8

	func (o *Client) ListExternalGroupMembers(ctx context.Context, groupId string) ([]*gitlabSDK.PendingInvite, *gitlabSDK.Response, error) {
	users, res, err := o.Invites.ListPendingGroupInvitations(groupId, &gitlabSDK.ListPendingInvitationsOptions{
	ListOptions: gitlabSDK.ListOptions{},
	},
	gitlabSDK.WithContext(ctx),
	)
	if err != nil {
	if res == nil {
	return nil, nil, fmt.Errorf("gitlab-connector: error listing external group members: %w", err)
	}
	// handle the case where the user does not have permissions to the external group
	if res.StatusCode != http.StatusForbidden {
	return nil, res, err
	}
	}
	return users, res, nil
	}

Fix in Cursor • Fix in Web

---

Was this report helpful? Give feedback by reacting with 👍 or 👎

[luisina-santos]

we should remove gitlabSDK usages for all versions as part of this change

[luisina-santos]

I think it's okay as initial PR, we could remove the sdk in a next PR?