Skip to content

Fix task processing while in one-shot mode#69

Merged
morgabra merged 2 commits into
mainfrom
jirwin/oneshot-fixes
Aug 16, 2023
Merged

Fix task processing while in one-shot mode#69
morgabra merged 2 commits into
mainfrom
jirwin/oneshot-fixes

Conversation

@jirwin
Copy link
Copy Markdown
Contributor

@jirwin jirwin commented Aug 16, 2023 •
edited
Loading

Also bumps the validation for the max size of pagination tokens for related connector APIs.

If we're running in one-shot mode, we want to run our single task synchronously instead of in a goroutine. This way we don't exit early while we're performing the work in the background.

@morgabra morgabra merged commit f03cf6d into main Aug 16, 2023
@morgabra morgabra deleted the jirwin/oneshot-fixes branch August 16, 2023 18:23
ggreer added a commit that referenced this pull request May 12, 2026
@ggreer @jirwin
@pquerna @abovee @mindymo @jakcinmarina @shackra @laurenleach @cvkramer @johnallers @claude
Merge baton CLI utility into baton-sdk. (#815)
6a94d48 
* Initial commit

* Add protos for diff outputs

* Fix proto lint

* Use upstream sdk instead of local vendored

* [docs] Work on initial README, COC, and Contributing Guide (#3)

Add initial README, COC, and Contributing guide.

* Changes to fix repo rename (#4)

* Update list resources command usage (#2)

* Update list resources command usage

* Resync modules

* Add output manager

* Add output format flag and use output manager in resource types

* resource types and resources updated to use output package

* Add output format support for grants and entitlements

* Update protos and source for package rename

* Lint fixes

* more lint fixes

* Add support for listing principals -- including by entitlement id and… (#5)

* Add support for listing principals -- including by entitlement id and resource

* Update readme with new usage

* Add 'access' command to output the effective access of a given resource (#6)

* Add 'access' command to output the effective access of a given resource

* Remove comment

* Update readme usage

* Add new dump-db command (#7)

* Better error handling for grants where the entitlement or resource is missing (#8)

* Add support for listing grants by resource type (#9)

* Bump sdk to v0.0.9 (#11)

* Compare principals across entitlements (#12)

* Add command for comparing the principals of two entitlements, possibly across C1Zs

* Add output for if principals match

* Update README (#10)

* Update readme

* fix setup link

* Fill out run example in readme

Co-authored-by: Justin Gallardo <justin.gallardo@conductorone.com>

* Normalize flags for filtering (#13)

* Normalize flags for filtering

* Use correct flag name for compare-entitlement

* make update-deps (#14)

* Bump sdk to v0.0.16 (#15)

* Put entrypoint into subdir for go install (#17)

* Update README.md (#16)

* Fix formatting in readme (#18)

* Prep for public release (#20)

* make update-deps

* git ignore csv and xlsx

* Use default download strategy for homebrew

* Edits to Readme (#21)

Fix repo links, remove link to nonexistent page, sentence case headings, general copy edits.

* Update README.md (#22)

* Update README.md

* improve image for video

* fix markdown syntax

* fixup image size

* Update README.md

* Add functionality for working with various syncs contained within a C1Z (#23)

* Add support for listing syncs and exporting syncs to a new c1z

* Add support for cloning a specific sync

* Add support for outputting sync runs

* Add support for specifying sync-id where applicable

* Use constant for time format

* Update baton-sdk

* Update SDK and other dependencies (#24)

* Upgrade sdk to v0.0.25

* upgrade golang.org/x/net

* Update CI to produce windows artifacts (#25)

* Show grant IDs in list grant output (#26)

* Bump baton-sdk to v0.0.29

* Include grant IDs in list grant output

* make update-deps (#27)

* Bump baton-sdk to v0.1.0 (#28)

* Bump baton-sdk to v0.1.0

* Set golang version to 1.20

* Don't use local baton-sdk

* Don't panic if the object isn't known (#29)

* Add full list of connectors to README (#30)

* Update README.md (#31)

update list of available Baton connectors

* Bump baton-sdk to v0.1.7 (#34)

* Add new optimize command (#36)

* Update baton-sdk

* Add new optimize command that optimizes a c1z on disk.

* don't use fmt.Println

* Use baton-sdk@v0.1.8 instead of the branch

* Update README.md (#38)

add recent connectors to index

* Add new connectors to list (#39)

* explorer ui - v0 (#33) (#40)

* explorer ui - v0

* tweaks

* fix id string split

* Load the c1z once per process, and share it and the store cache across requests

* grant expansion support, group resources by type

* ui redesign, node highlight, dark theme

* serve static html, add hidden dev mode flag for development

* lint error

* dashboard (#37)

* dashboard ui WIP

* dashboard inventory, misc fixes

* UI tweaks

* In non-dev mode, use embed to serve files instead of the filesystem. Build frontend as part of make.

* Commit built js so that go tests don't need npm to run.

* Serve up index.html for 404s.

---------

Co-authored-by: jakcinmarina <52315405+jakcinmarina@users.noreply.github.com>
Co-authored-by: Justin Gallardo <justin.gallardo@conductorone.com>

* Baton Explorer cleanup (#41)

* Baton Explorer cleanup

- Prevent an infinite loop of opening/closing resource lists if visiting /groups/ (trailing slash)
- Add some dependencies in useEffect()s
- Fix a warning about Selects not containing values if there's just one entitlement.
- Add a type annotation to EntitlementMenu's handleChange.

* Rebuild js

* Fix buf lint.

* Update README.md (#42)

add new connectors to index in readme

* Fix release. Upgrade baton-sdk (#43)

* Fix release.

* Upgrade baton-sdk.

* Update connector list in README.md (#44)

* Add new connectors to Readme index (#45)

* Update README.md (#46)

* Upgrade dependencies (#47)

* Upgrade dependencies

* Bump go version for CI

* Bump to go 1.22

* Upgrade and fix goreleaser configuration (#48)

* Add a flake and offer baton as a package for nix/NixOS (#50)

* Add a flake and offer baton as a package

* Expand the README

* Remove linter `exportloopref` since it is deprecated

* Remove linter `execinquery` since the project was archived by the author

* Update README.md (#51)

Use correct attribute to set URL of input

* Upgrade baton-sdk. Upgrade github actions. Fix goreleaser. (#52)

* Upgrade baton-sdk to v0.2.61.

* Upgrade github actions. Fix goreleaser.

* Update the list of connector repos (#53)

* Upgrade baton-sdk to v0.2.64. (#54)

* Update dependencies, including baton-sdk@v0.2.67 (#55)

* Update dependencies, including baton-sdk@v0.2.67

* Update go version used in CI

* Update input for nixpkgs to unstable (#56)

* bump baton-sdk version to support new BatonID annotation (#58)

* Update README.md (#57)

Proposing removing the list of Baton connectors from this README, as it's huge and ever-expanding.

* bump baton-sdk version to v0.2.90 (#59)

* Upgrade baton-sdk to v0.2.94. (#60)

Adds support for Raw ID annotation.

* Update CONTRIBUTING.md (#62)

Remove deprecated site and reference

* Show new partial sync data. (#63)

* Show new partial sync data.

* Upgrade buf version.

* Upgrade baton-sdk to v0.3.2. (#64)

* Upgrade baton-sdk to v0.4.0. (#65)

* Fix release.

* Bump baton-sdk to 0.6.17 (#67)

* Bump baton-sdk to 0.6.17

* Update sync type when calculating stats.

* Upgrade baton-sdk to v0.7.3. (#68)

* Add --resource-type filter to listing entitlements. (#69)

* Upgrade baton-sdk to v0.7.27. (#70)

* Fix temp directory leak by closing C1File store in all commands (#72)

Most commands only called m.Close() (which removes the temp c1z copy)
but never called store.Close() (which cleans up the decompressed SQLite
temp directory). This caused temp directories to accumulate on every
invocation. Also fixes principals_compare.go which was closing the wrong
manager (m instead of mCompare) and adds missing m.Close() to c1z.go.

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>

* go get -u ./... && go mod tidy && go mod vendor (#73)

* Big refactor to baton explorer (#74)

* Big refactor to baton explorer

* Add profile data to the table.

* Better favicon

* Fix asset distribution and use 'prod' mode (#75)

* Fix asset distribution and use 'prod' mode

* Lint fix

* bump baton-sdk to v0.8.24 (#77)

* Merge baton CLI utility into baton-sdk.

* Fix deprecation lint error. Use s3 transfermanager instead of s3manager.NewDownloader.

* Merge flake files for baton & baton-sdk.

* Move baton-cli specific files into pkg/baton. Change makefile to output binary to baton, not baton-sdk.

---------

Co-authored-by: Justin Gallardo <justin.gallardo@conductorone.com>
Co-authored-by: Paul Querna <pquerna@apache.org>
Co-authored-by: abovee <abovee@gmail.com>
Co-authored-by: Mindy Moreland <mindy.moreland@conductorone.com>
Co-authored-by: jakcinmarina <52315405+jakcinmarina@users.noreply.github.com>
Co-authored-by: Jorge Araya Navarro <jorge@esavara.cr>
Co-authored-by: laurenleach <106626058+laurenleach@users.noreply.github.com>
Co-authored-by: Charles Kramer <cvkramer@gmail.com>
Co-authored-by: John Allers <john.allers@gmail.com>
Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@morgabra morgabra morgabra approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jirwin @morgabra