CXH-1582: Surface role and group access in redshift connector#133
Merged
Conversation
staticEntitlements() in pkg/bsql/entitlements.go did not populate v2.Entitlement.GrantableTo from the YAML grantable_to field, so role and group principal grants on static entitlements were dropped during C1 ingest. Mirror the resource-type lookup from mapEntitlement() so static entitlements honor the configured types. In examples/redshift-test.yml, widen grantable_to to include role and group on the affected privilege entitlements, and attach expandable annotations on every role/group grant map entry so the SDK fans the grants out to member users at sync time. Verified against the local Postgres-as-Redshift stub: group analysts' members alice and bob now appear as derived user grants on schema:analytics.reports:usage.
Contributor
Connector PR Review: CXH-1582: Surface role and group access in redshift connectorBlocking Issues: 0 | Suggestions: 0 | Threads Resolved: 0 Review SummaryThe new commits since the last review are a lint fix converting Security IssuesNone found. Correctness IssuesNone found. SuggestionsNone. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
luisina-santos
approved these changes
Jun 3, 2026
johnallers
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Redshift access granted through a role or group now shows up in C1, including the individual users who inherit that access through their memberships.