Skip to content

update deps & remove generated protos#18

Merged
ennyjfrick merged 2 commits intomainfrom
ejf/update-deps
Jul 31, 2024
Merged

update deps & remove generated protos#18
ennyjfrick merged 2 commits intomainfrom
ejf/update-deps

Conversation

@ennyjfrick
Copy link
Copy Markdown
Contributor

Description

Updates dependencies and removes dependency on hand-generated protobufs in favor of Temporal's generated protobufs.

Also fixes a bug where Go programs will fail to compile due to duplicated protobuf registration if they import both this package and the Temporal SDK.

  • Bug fix
  • New feature

Useful links:

  • [https://github.com/ConductorOne/baton-sdk/wiki/Coding-Guidelines](Baton SDK coding guidelines)
  • [https://github.com/ConductorOne/baton/blob/main/CONTRIBUTING.md](New contributor guide)

@ggreer
Copy link
Copy Markdown
Contributor

ggreer commented Jul 31, 2024

CI tests are failing because the setup temporal cloud job is failing but reporting success.

ID=$(tcld user get --user-email "ci-test@${{ secrets.TEST_EMAIL_DOMAIN}}" | jq --exit-status '.id' | tr -d '"'); echo "user=$ID" >> "$GITHUB_OUTPUT"

Should be

ID=$(tcld user get --user-email "ci-test@${{ secrets.TEST_EMAIL_DOMAIN}}" | jq --exit-status '.id' | tr -d '"') && echo "user=$ID" >> "$GITHUB_OUTPUT"

(using && instead of ; between commands)

Then recreate the ci-test user and we can see if grant/revoke works.

@ennyjfrick ennyjfrick merged commit 11f502f into main Jul 31, 2024
@ennyjfrick ennyjfrick deleted the ejf/update-deps branch July 31, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants