Skip to content

Conversation

@gontzess
Copy link
Contributor

separates out the steps and config files for docker OCI and docker Lambda.

in a followup PR we'll be pushing OCI docker images to a public ECR so we can't use multiple aws roles in a single config.

also moves some templates to a /templates folder. in the future we'll depreciate/remove releases for v1-v2 so that we can clean up existing the top level template files.

@coderabbitai
Copy link

coderabbitai bot commented Dec 16, 2025

Important

Review skipped

Review was skipped due to path filters

⛔ Files ignored due to path filters (9)
  • .github/workflows/release.yaml is excluded by none and included by none
  • .goreleaser-docker-template-no-lambda.yaml is excluded by none and included by none
  • .goreleaser-docker-template.yaml is excluded by none and included by none
  • .goreleaser-template.yaml is excluded by none and included by none
  • templates/.Dockerfile-lambda-template is excluded by none and included by none
  • templates/.Dockerfile-template is excluded by none and included by none
  • templates/.goreleaser-binaries-template.yaml is excluded by none and included by none
  • templates/.goreleaser-docker-lambda-template.yaml is excluded by none and included by none
  • templates/.goreleaser-docker-oci-template.yaml is excluded by none and included by none

CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including **/dist/** will override the default block on the dist directory, by removing the pattern from both the lists.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch gontzess/push-dockers-to-ecr

Comment @coderabbitai help to get the list of available commands and usage tips.

@gontzess gontzess requested review from ggreer and kans December 16, 2025 17:05
@@ -13,8 +13,6 @@ builds:
goarch:
- amd64
- arm64
tags:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kans this is now removed from the OCI image build

@@ -28,40 +26,21 @@ dockers_v2:
dockerfile: ${DOCKERFILE_PATH}
ids:
- linux
disable: '{{ ne .Env.DOCKER "true" }}'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conditionals are now handled at the workflow step level

@gontzess gontzess merged commit 084349e into main Dec 16, 2025
1 check passed
@gontzess gontzess deleted the gontzess/push-dockers-to-ecr branch December 16, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants