-
Notifications
You must be signed in to change notification settings - Fork 0
separate docker OCI and docker lambda #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (9)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Comment |
| @@ -13,8 +13,6 @@ builds: | |||
| goarch: | |||
| - amd64 | |||
| - arm64 | |||
| tags: | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kans this is now removed from the OCI image build
| @@ -28,40 +26,21 @@ dockers_v2: | |||
| dockerfile: ${DOCKERFILE_PATH} | |||
| ids: | |||
| - linux | |||
| disable: '{{ ne .Env.DOCKER "true" }}' | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conditionals are now handled at the workflow step level
separates out the steps and config files for docker OCI and docker Lambda.
in a followup PR we'll be pushing OCI docker images to a public ECR so we can't use multiple aws roles in a single config.
also moves some templates to a
/templatesfolder. in the future we'll depreciate/remove releases for v1-v2 so that we can clean up existing the top level template files.