Skip to content

Verify release checkouts use tag commits#75

Merged
gontzess merged 1 commit into
mainfrom
gontzess/release-tag-checkout
May 13, 2026
Merged

Verify release checkouts use tag commits#75
gontzess merged 1 commit into
mainfrom
gontzess/release-tag-checkout

Conversation

@gontzess
Copy link
Copy Markdown
Contributor

@gontzess gontzess commented May 13, 2026

Why

The release workflow accepts a tag input and then builds, signs, uploads, and records release metadata. The caller checkout should be tied directly to that tag so a release run cannot publish artifacts from one commit while labeling or recording them as another tag.

What this changes

  • Checks out caller code from refs/tags/${{ inputs.tag }} in the binaries, Windows, Docker, and registry metadata jobs.
  • Verifies each checked-out caller repository HEAD matches the tag target before continuing.
  • Records the verified connector checkout commit SHA in the registry metadata instead of using github.sha.
  • Documents the release source identity invariant in the release workflow docs.

This PR is stacked on #74 and should merge after it.

Validation

  • Parsed .github/workflows/release.yaml with yq.
  • Ran git diff --check.
  • Verified all caller/connector release checkouts use refs/tags/${{ inputs.tag }}.
  • Ran orch-cross-review focused on annotated/lightweight tags, cross-runner behavior, registry commit recording, and regressions; no blockers were reported.
  • Ran a private connector release canary against this branch; the release completed successfully, including macOS, Windows, Docker, manifest publication, artifact verification, and registry recording jobs.

Base automatically changed from gontzess/disable-release-caches to main May 13, 2026 15:49
@gontzess gontzess force-pushed the gontzess/release-tag-checkout branch from f818ca2 to a7d0411 Compare May 13, 2026 15:50
@gontzess gontzess requested review from ggreer and kans May 13, 2026 15:52
@gontzess gontzess merged commit 8cf5035 into main May 13, 2026
1 check passed
@gontzess gontzess deleted the gontzess/release-tag-checkout branch May 13, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants