Verify release checkouts use tag commits#75
Merged
Conversation
f818ca2 to
a7d0411
Compare
kans
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The release workflow accepts a tag input and then builds, signs, uploads, and records release metadata. The caller checkout should be tied directly to that tag so a release run cannot publish artifacts from one commit while labeling or recording them as another tag.
What this changes
refs/tags/${{ inputs.tag }}in the binaries, Windows, Docker, and registry metadata jobs.github.sha.This PR is stacked on #74 and should merge after it.
Validation
.github/workflows/release.yamlwithyq.git diff --check.refs/tags/${{ inputs.tag }}.orch-cross-reviewfocused on annotated/lightweight tags, cross-runner behavior, registry commit recording, and regressions; no blockers were reported.