Fix MDX lint URL false positives in prose#79
Merged
Conversation
JavierCarnelli-ConductorOne
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Connector docs can contain ordinary prose such as “To sync (read) data:”. The MDX validator was scanning all text nodes for dangerous URL schemes, so that prose failed as if it were an actual data URL. Connector repos should not need wording-only PRs to work around that false positive.
What this changes
Narrows dangerous URL checks to URL-bearing markdown nodes and JSX attributes. Plain text is no longer scanned as a URL, while links, images, definitions, href/src/action attributes, and encoded dangerous URL schemes remain blocked.
Adds a regression test for the Sentry-style Step content that triggered the failure.
Validation
Rollout
After merge, publish the updated reusable workflow ref used by connector repos. They currently call ConductorOne/github-workflows at v4, so v4 must point at this fix before baton-sentry main stops using the old validator.