Fix Public ECR release tag publishing#95
Merged
Conversation
30f88c1 to
f2f44d2
Compare
f2f44d2 to
3a74beb
Compare
jugonzalez12
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Public ECR tag helper currently calls
aws ecr-public batch-get-image, but ECR Public does not expose that AWS CLI operation. Go connector releases with Docker enabled can push and sign the temporary candidate image, then fail before the version tag, manifest publication, and registry recording.What this changes
Fetch the candidate manifest through Docker registry tooling with
docker buildx imagetools inspect --raw <image>@<digest>, then keep the existing ECRPutImagepromotion and post-write digest assertion. The helper now passes the expected candidate digest intoPutImage, refuses to send non-release-candidate-<run>-<attempt>tags toBatchDeleteImage, and the tests model AWS and Docker separately so the fake AWS runner no longer accepts an invalid ECR Public command.Cleanup remains best-effort: if
BatchDeleteImageis denied, release publication still succeeds after the real version tag andlatestare written and verified.Validation
go test ./cmd/publish-public-ecr-release-tagsmake test