Skip to content

Run Windows S3 uploads from PowerShell#96

Merged
gontzess merged 1 commit into
mainfrom
gontzess/fix-windows-s3-upload
Jun 5, 2026
Merged

Run Windows S3 uploads from PowerShell#96
gontzess merged 1 commit into
mainfrom
gontzess/fix-windows-s3-upload

Conversation

@gontzess
Copy link
Copy Markdown
Contributor

@gontzess gontzess commented Jun 5, 2026

Why

The shared release workflow now fails Windows MSI releases during S3 upload with SignatureDoesNotMatch after moving that path onto the Bash-based s3api put-object helper. The Docker/Public ECR hotfix is being picked up; this is a separate Windows artifact upload failure that blocks manifest publication and registry recording.

The Windows upload path also needs explicit native-command failure handling so an upload failure cannot be lost inside a loop.

What this changes

  • Adds a Windows-native PowerShell S3 artifact uploader that keeps the existing immutable upload behavior: preflight existing objects by sha256 metadata, upload with PutObject plus If-None-Match: *, and fail if an existing object has different or missing sha256 metadata.
  • Switches only the Windows artifact upload step to pwsh; macOS/Linux binary uploads continue using the existing Bash helper.
  • Adds PowerShell coverage for artifact selection and fail-closed put-object errors, wired into make test when pwsh is available.

Validation

The HubSpot test release passed end to end. The previously failing release / goreleaser-windows job passed Upload Windows artifacts to S3, then publish-release-manifest, verify-release, and record-registry-api all passed. Registry API shows ConductorOne/baton-hubspot v0.0.10-test.1 as VERSION_STATE_PUBLISHED with Windows ZIP/MSI assets, manifest/signature URLs, and image digests.

Note: local make test skipped the PowerShell test because pwsh is not installed on this machine; the live windows-latest release run exercised the PowerShell helper in the actual release path.

@gontzess gontzess marked this pull request as ready for review June 5, 2026 21:05
@gontzess gontzess requested a review from a team June 5, 2026 21:05
Copy link
Copy Markdown

@jugonzalez12 jugonzalez12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems legit, powershell is the devil

@gontzess gontzess marked this pull request as draft June 5, 2026 21:10
@gontzess gontzess marked this pull request as ready for review June 5, 2026 21:10
@gontzess gontzess merged commit 5d9a0b6 into main Jun 5, 2026
4 checks passed
@gontzess gontzess deleted the gontzess/fix-windows-s3-upload branch June 5, 2026 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants