Run Windows S3 uploads from PowerShell#96
Merged
Conversation
jugonzalez12
approved these changes
Jun 5, 2026
jugonzalez12
left a comment
There was a problem hiding this comment.
seems legit, powershell is the devil
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The shared release workflow now fails Windows MSI releases during S3 upload with
SignatureDoesNotMatchafter moving that path onto the Bash-baseds3api put-objecthelper. The Docker/Public ECR hotfix is being picked up; this is a separate Windows artifact upload failure that blocks manifest publication and registry recording.The Windows upload path also needs explicit native-command failure handling so an upload failure cannot be lost inside a loop.
What this changes
PutObjectplusIf-None-Match: *, and fail if an existing object has different or missing sha256 metadata.pwsh; macOS/Linux binary uploads continue using the existing Bash helper.put-objecterrors, wired intomake testwhenpwshis available.Validation
make testmake workflow-validategit diff --cached --checkorch-cross-review --provider codexfound no blocker; it noted the localpwshskip as a low test-gate gap.v0.0.10-test.1: https://github.com/ConductorOne/baton-hubspot/actions/runs/27040354513The HubSpot test release passed end to end. The previously failing
release / goreleaser-windowsjob passedUpload Windows artifacts to S3, thenpublish-release-manifest,verify-release, andrecord-registry-apiall passed. Registry API showsConductorOne/baton-hubspotv0.0.10-test.1asVERSION_STATE_PUBLISHEDwith Windows ZIP/MSI assets, manifest/signature URLs, and image digests.Note: local
make testskipped the PowerShell test becausepwshis not installed on this machine; the livewindows-latestrelease run exercised the PowerShell helper in the actual release path.