returns snapshot incomplete error when snapshot is interrupted #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s into dylan/snapshot-iterator
dylanlott
commented
Apr 6, 2022
hariso
reviewed
Apr 7, 2022
| // Teardown attempts to gracefully teardown the iterator. | ||
| func (s *SnapshotIterator) Teardown(ctx context.Context) error { | ||
| s.rows.Close() | ||
| if commitErr := s.tx.Commit(ctx); commitErr != nil { |
Contributor
There was a problem hiding this comment.
Might be a dumb question, but why do we call s.tx.Commit() here at all?
Contributor
There was a problem hiding this comment.
Simply to end the transaction.
Contributor
There was a problem hiding this comment.
Ah, I think I need a break.:D I was thinking this is the source teardown, but it's the iterator teardown, and actually a different thing in mind because of that.
dylanlott
force-pushed
the
dylan/teardown
branch
from
27ba7c9 to
b544e42
Compare
lovromazgon
reviewed
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returns an
ErrSnapshotInterruptwhen a snapshot is stopped before it's finished.Creates the
ErrSnapshotCompletevariable in anticipation of creating theCombinedIteratorAddresses #22 (comment)
Quick checks: