Skip to content

Fix TestRelationSetAllTypes #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 9, 2022
Merged

Fix TestRelationSetAllTypes #39

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2085b98
allow for empty transactions in TestRelationSetAllTypes
lovromazgon May 2, 2022
11f3bb7
simplify
lovromazgon May 9, 2022
17f0c4a
Merge branch 'main' into lovro/fix-flaky-test
lovromazgon May 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 22 additions & 4 deletions source/logrepl/internal/relationset_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,10 +54,28 @@ func TestRelationSetAllTypes(t *testing.T) {
_, messages := setupSubscription(ctx, t, conn.Config().Config, table)
insertRowAllTypes(ctx, t, conn, table)

<-messages // skip first message, it's a begin message
rel := (<-messages).(*pglogrepl.RelationMessage) // second message is a relation
ins := (<-messages).(*pglogrepl.InsertMessage) // third one is the insert
<-messages // fourth one is the commit
var rel *pglogrepl.RelationMessage
var ins *pglogrepl.InsertMessage

// loop through messages and allow for empty transactions to be received
for {
// first message needs to be a begin message
msg := <-messages
_ = msg.(*pglogrepl.BeginMessage)

// second message can be either commit (we can catch empty transactions)
// or relation (that's what we are actually interested in)
msg = <-messages
if _, ok := msg.(*pglogrepl.CommitMessage); ok {
continue // empty transaction, skip it
}

// not an empty transaction, these have to be the messages we are looking for
rel = msg.(*pglogrepl.RelationMessage) // second message is a relation
ins = (<-messages).(*pglogrepl.InsertMessage) // third one is the insert
_ = (<-messages).(*pglogrepl.CommitMessage) // fourth one is the commit
break
}

rs := NewRelationSet(conn.ConnInfo())

Expand Down