This repository was archived by the owner on Dec 20, 2024. It is now read-only.
fix(tabs): make hover/focus/active states more user-friendly#21
Merged
fix(tabs): make hover/focus/active states more user-friendly#21
Conversation
🦋 Changeset detectedLatest commit: 6934762 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Test coverage: 92.29% 🤷♂️ Did not change |
jayjayjpg
force-pushed
the
jj/tabs-in-solid-focus
branch
from
45a23a6 to
6934762
Compare
Contributor
|
Test coverage: 92.29% 🤷♂️ Did not change |
nassor
approved these changes
Nov 1, 2022
justmisosoup
approved these changes
Nov 1, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of https://github.com/meroxa/platform-ui-v1/issues/617
With this change the
Tabs::Itemcomponent will have a consistent:activestate: regardless if a user hovers over, focusses in or blurs the element, theactivestyle will be preserved. Additionally, this ensures that the style of the previously used:focusstate is only shown on inactive elements the user hovers over.Demo