Skip to content

Conversation

@kon14
Copy link
Contributor

@kon14 kon14 commented Nov 26, 2022

This PR introduces checks for Docker availability.
Checks only added in commands that require Docker.
Checks take place early on so as to abort before any user input.

On macOS, if Docker is available, but not running, CLI will attempt to automatically start the Docker daemon.
I'll follow up with a proper implementation for Linux on a followup PR as that would be init system-specific and most likely fail anyway due to systemctl permissions.

Users without a Docker installation or a prestarted Docker daemon, and for whom auto-start fails, can now expect to come across a human readable error prompting them to install Docker or start its daemon, regardless of platform.

I had to resort to some meh-tier Docker/DockerCompose (class) refactors due to an oclif bug resulting in code executing during builds (oclif manifest).

What kind of change does this PR introduce?

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other (please describe)

Does this PR introduce a breaking change?

  • Yes
  • No

The PR fulfills these requirements:

  • It's submitted to the main branch
  • When resolving a specific issue, it's referenced in the PR's description (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature

@kkopanidis kkopanidis merged commit e2f53ed into main Nov 28, 2022
@kkopanidis kkopanidis deleted the docker-checks branch November 28, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants