Skip to content

refactor: change tab title case, and rename schemas to models#228

Merged
kkopanidis merged 2 commits intomainfrom
db-renames
Mar 20, 2023
Merged

refactor: change tab title case, and rename schemas to models#228
kkopanidis merged 2 commits intomainfrom
db-renames

Conversation

@kkopanidis
Copy link
Copy Markdown
Contributor

refactor: change tab menus to PascalCase
refactor(database): change all mentions of schema to model for clarity
fix(database): skip/limit params in query requests being sent as body
fix(database): custom endpoint documentation pointed to the wrong url

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix #xxx, where "xxx" is the issue number)

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

refactor(database): change all mentions of schema to model for clarity
fix(database): skip/limit params in query requests being sent as body
@kkopanidis kkopanidis requested review from kon14 and ssellas March 18, 2023 11:58
fields of different types. Some of them are optional, while others are
required. Some of them might even take a default value if nothing else is
explicitly specified.
Custom content types are expressed as Models which are created in the
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rephrase this a bit, but more specifically is the capital M intended?

ex:
Custom content types are expressed through models, represented as database schemas. Models contain fields of different types, some of which are mandatory while others are optional. Some of them may even accept a default value if none is explicitly provided.

@kon14 kon14 self-requested a review March 20, 2023 15:09
@kkopanidis kkopanidis merged commit 647447e into main Mar 20, 2023
@kkopanidis kkopanidis deleted the db-renames branch March 20, 2023 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants