refactor(authorization): rework query logic and caches to improve performance of authz lookups#1447
Merged
kkopanidis merged 1 commit intomainfrom Mar 20, 2026
Merged
Conversation
ChrisPdgn
reviewed
Mar 20, 2026
| entity: { $in: candidateEntities }, | ||
| }); | ||
| return !!objectDefinition; | ||
| return !!matchingActorIndex; |
Contributor
There was a problem hiding this comment.
I don't know if this is an issue, but in the final case of this method why do we check if there is a matching actor index and in all the other cases we only look for object indexes?
Contributor
Author
There was a problem hiding this comment.
Because the idea is to reverse the lookup so that we can limit results sooner. Instead of saying to which objects does the user have access, we say which objects would be of interest, and then from those, who has access?
…formance of authz lookups
kkopanidis
force-pushed
the
authorization/performance-enhancements
branch
from
96899c4 to
a2540ea
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
Other information: