fix(email)!: attachments#1452
Merged
kkopanidis merged 1 commit intomainfrom Apr 2, 2026
Merged
Conversation
ChrisPdgn
approved these changes
Apr 2, 2026
78b32c4 to
852ecd0
Compare
Contributor
|
If I were to merge this with this title, it'd trigger a larger bump than the intended. Considering this functionality is already broken, I'll change the title slightly |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Does this PR introduce a breaking change?
attachments?: string[];to
ISendEmailParams went from attachments?: string[] to Attachment[].
SendEmailParams.attachments in email.proto changed from repeated string to repeated Attachment
any caller will now fail type checking and may also fail at runtime if not updated.
callers who never set attachments are largely unaffected (still optional).
The PR fulfills these requirements:
mainbranchfix #xxx, where "xxx" is the issue number)If adding a new feature, the PR's description includes:
As I understand it (not my branch), we replaced an unspecified string[] with a proper attachment message (from node mailer) so we can send binary content, correct MIME types, and URL-based attachments.
The only thing you could send through gRPC was text strings and then the email module did try to get the file from storage / a path the email service could read. Now we can send payload over gRPC as bytes in a proper attachment shape.