docs: add alternatives, glossary, and why-a-gateway - #6
Merged
Conversation
Three docs aimed at a first-time reader, plus one npm keyword. - alternatives.md: how krm-stream differs from Kubernetes client libraries, browser dashboards, config-as-data systems, and CRDTs. gitops-reverser is covered as the write half of the same loop rather than as a competitor. - glossary.md: the Kubernetes vocabulary a frontend developer needs, and where each term appears in the library. - why-a-gateway.md: why a browser cannot watch the API server (the obstacle is the credential, CORS and whole objects, not a protocol upgrade), and why SharedBackend opens one watch per scope. The README carries a short "why" and links out to the last of these. Also adds config-as-data to the npm keywords. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe changes add documentation for gateway architecture, frontend terminology, and related projects; update README guide links; and add ChangesDocumentation and metadata
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Three new docs for a first-time reader, plus one npm keyword.
docs/alternatives.md — where krm-stream sits relative to existing work: Kubernetes client libraries, browser dashboards (Headlamp is the closest architectural precedent for the gateway, not hawtio), config-as-data systems, and CRDT/merge libraries. Ends with the claim we can actually defend, which is the combination rather than "first Kubernetes streaming library". gitops-reverser is covered as the write-and-record half of the same loop rather than as a competitor, and is deliberately absent from the comparison table for that reason.
docs/glossary.md — the Kubernetes vocabulary a frontend developer needs, on the assumption that a first-time user of this library may never have touched a cluster. About a dozen terms, then a walk of the read and write paths that pins each term to a real place in the code.
docs/why-a-gateway.md — why the browser cannot watch the API server directly, and why watches are shared. The README carries a short version and links here.
config-as-dataadded to the npm keywords; it ships with the next release-please cut.Two things worth a reviewer's attention
A watch is not a protocol upgrade. It is a plain
GET ?watch=1returning chunked newline-delimited JSON. Upgrades are whatexec/attach/port-forwardneed. The real obstacles to watching from a browser are the cluster credential, the absence of CORS on the API server, and the fact that a watch returns whole objects includingSecretdata. The doc says that, and says the transport is explicitly not the problem.ValidateMergePatchdoes not blanket-blockstatus. Reading gateway/patch.go: it rejects redacted paths,metadata.managedFieldsand the last-applied annotation always, but/statusonly underProjectionSpec. The glossary states it that way rather than the broader claim.Docs only, plus one keyword.
task lint-clientpasses.🤖 Generated with Claude Code
Summary by CodeRabbit