Clarify [Rs, Rr] time-sign semantics and restore correct QMD/IMD freedom for improper-operation inputs#19
Draft
Clarify [Rs, Rr] time-sign semantics and restore correct QMD/IMD freedom for improper-operation inputs#19
Conversation
Co-authored-by: Connor1y <55659348+Connor1y@users.noreply.github.com>
Co-authored-by: Connor1y <55659348+Connor1y@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add solve_qmd and solve_imd functions for calculations
Clarify [Rs, Rr] time-sign semantics and restore correct QMD/IMD freedom for improper-operation inputs
Mar 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The issue was caused by ambiguous time-reversal handling for
[Rs, Rr]transformations: determinant-based inference was over-constraining QMD/IMD for mixed improper operations. For the reported input class, this collapsed expected tensor freedoms (QMD 4 / IMD 3) into incorrect lower-dimensional solutions.Core parser semantics
parse_transformation()so[Rs, Rr]no longer infers anti-unitary/time-reversal sign.[Rs, Rr],s_Tis now fixed to+1; anti-unitary operations are represented explicitly via[Tflag, Rr].Rrdrives axis transform ands_Pviadet(Rr)^P_constraint).Behavioral alignment in rank-3 convenience paths
[Rs, Rr]inputs used bysolve_qmd()/solve_imd().Targeted test updates
[Tflag, Rr]representation.[Rs, Rr] -> [Tflag, Rr]where needed, reducing repeated conversion logic.🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.