Skip to content

allow None in param shape#74

Merged
ConnorStoneAstro merged 5 commits intomainfrom
noneshape
Feb 10, 2026
Merged

allow None in param shape#74
ConnorStoneAstro merged 5 commits intomainfrom
noneshape

Conversation

@ConnorStoneAstro
Copy link
Owner

Param shape can now have None as an entry. It will take the size of that dimension from the param value if available. This allows specifying the structure of a param without specifying the exact shape. Such as requiring an entry to be an image (2D with shape (None, None)) of any size.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (892bd28) to head (dba7285).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #74   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           13        13           
  Lines         1521      1521           
=========================================
  Hits          1521      1521           
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link

@mjyb16 mjyb16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a couple small things to clarify: does shape = None just assume no shape at all, and does shape = (None, ) assume a 1D shape?

@ConnorStoneAstro
Copy link
Owner Author

Looking good! Just a couple small things to clarify: does shape = None just assume no shape at all, and does shape = (None, ) assume a 1D shape?

That's right! Good point though, I'll make that clear in the docs.

@ConnorStoneAstro ConnorStoneAstro added the enhancement New feature or request label Feb 10, 2026
@ConnorStoneAstro ConnorStoneAstro merged commit 36e7382 into main Feb 10, 2026
33 checks passed
@ConnorStoneAstro ConnorStoneAstro deleted the noneshape branch February 10, 2026 14:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments