[V4] benchmark skeleton #48

ConorWilliams · 2026-01-21T21:46:11Z

Add benchmark scaffolding (google benchmark)

Copilot

Pull request overview

Introduces an initial benchmarking scaffold for libfork v4, alongside minor core/layout assertions and build/CI wiring to support running benchmarks in developer mode.

Changes:

Add Google Benchmark target with an initial Fibonacci “serial” benchmark and shared helpers.
Introduce libfork_DEV_MODE to gate tests/benchmarks, and update presets/workflows to install benchmark dependencies.
Add a version header smoke test and refine internal promise/frame layout types/assertions.

Reviewed changes

Copilot reviewed 14 out of 15 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
`test/src/version.cpp`	Adds a Catch2 test to validate version macros are present and reasonable.
`src/core/promise.cxx`	Refactors promise/frame layout structs and adds layout-related `static_assert`s.
`include/libfork/version.hpp`	Adds `#pragma once` to the public version header.
`include/libfork/macros.hpp`	Adds public macros for exception/no-exception builds (`LF_TRY`, `LF_THROW`, etc.).
`benchmark/src/libfork_benchmark/fib/serial.cpp`	Adds a baseline serial Fibonacci benchmark.
`benchmark/src/libfork_benchmark/fib/fib.hpp`	Adds shared Fibonacci parameters and a reference implementation.
`benchmark/src/libfork_benchmark/common.hpp`	Adds common benchmark helpers (result checking + exception integration).
`benchmark/CMakeLists.txt`	Defines the benchmark executable, dependencies, and a dry-run test hook.
`LICENSE.md`	Adds MPL 2.0 license text.
`CMakeUserPresets.json`	Adds a user preset workflow for benchmark builds/tests.
`CMakePresets.json`	Enables `libfork_DEV_MODE` in CI presets and tweaks release flags.
`CMakeLists.txt`	Adds `libfork_DEV_MODE` option and wires benchmarks/tests behind it; exports `macros.hpp`.
`.github/workflows/macos.yml`	Installs `google-benchmark` in CI.
`.github/workflows/linux.yml`	Installs `google-benchmark` in CI.
`.github/workflows/linear.yml`	Updates checkout action version and minor formatting.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

include/libfork/macros.hpp

benchmark/src/libfork_benchmark/common.hpp

test/src/version.cpp

ConorWilliams · 2026-01-23T22:32:01Z

@copilot please resolve the comments you have made on this PR and suggest any further improvements

Copilot · 2026-01-23T22:32:09Z

@ConorWilliams I've opened a new pull request, #49, to work on those changes. Once the pull request is ready, I'll request review from you.

…prove error messages Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

include/libfork/macros.hpp

Copilot · 2026-01-23T23:00:00Z

@ConorWilliams I've opened a new pull request, #51, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

* mv license * same checkout version * move to frame * casting checks * cmake for benchmark * fib * add benchmark dep * new benchmark structure * pragma once on headers * version test * better version test * add src * strip prefix * bench preset * benchmark as a test * add benchmark test to preset * move to todo * use variables * drop no plt * rename * proper fib benchmark * drop todo * spell * macros * no-except safe * even better errors * exception safe * Resolve review comments: add include guard, fix macro evaluations, improve error messages Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Complete review comment resolution Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Add CodeQL symlink to .gitignore Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Update .gitignore * Add Fibonacci serial benchmark with direct return Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Complete: Add Fibonacci serial benchmark with direct return Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Remove CodeQL artifact and update gitignore Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Fix .gitignore formatting Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Remove doxygen-specific bits from macros.hpp Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * Complete removal of doxygen-specific bits Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com> * undo _codeql shenanigens * reoder bench naming convention * shorten * macros * prevent loop invariant lifting * spell * use do-not opt for basic fib as well

Conor added 9 commits January 21, 2026 20:07

mv license

38f8b2e

same checkout version

407720d

move to frame

a510257

casting checks

193a726

cmake for benchmark

057f1f8

fib

581f251

add benchmark dep

a34a86c

new benchmark structure

30a6a91

pragma once on headers

fda46d7

ConorWilliams force-pushed the v4-promise branch from e151f86 to f4647ef Compare January 23, 2026 15:14

Conor added 4 commits January 23, 2026 15:22

version test

f0aa9d9

better version test

7ab7649

add src

74b1c8f

strip prefix

eb45861

ConorWilliams force-pushed the v4-promise branch from 3c49033 to eb45861 Compare January 23, 2026 15:22

Conor added 5 commits January 23, 2026 15:45

bench preset

3af61ac

benchmark as a test

f3e80ed

add benchmark test to preset

7af695b

move to todo

6ed08f2

use variables

658b6c6

ConorWilliams changed the title ~~[V4] promise~~ [V4] benchmark skeleton Jan 23, 2026

Conor added 8 commits January 23, 2026 19:39

drop no plt

1314a50

rename

a846d17

proper fib benchmark

7c3fc0f

drop todo

1927cd7

spell

d4f17ba

macros

83e95b9

no-except safe

53e25c7

even better errors

5ee0048

ConorWilliams force-pushed the v4-promise branch from 769f57a to 5ee0048 Compare January 23, 2026 21:07

exception safe

40571ca

ConorWilliams requested a review from Copilot January 23, 2026 21:56

Copilot started reviewing on behalf of ConorWilliams January 23, 2026 21:57 View session

Copilot AI reviewed Jan 23, 2026

View reviewed changes

include/libfork/macros.hpp Show resolved Hide resolved

include/libfork/macros.hpp Show resolved Hide resolved

benchmark/src/libfork_benchmark/common.hpp Show resolved Hide resolved

test/src/version.cpp Outdated Show resolved Hide resolved

Copilot AI mentioned this pull request Jan 23, 2026

Address code review feedback: include guards, macro safety, and error messages #49

Merged

Copilot AI and others added 4 commits January 23, 2026 22:52

Resolve review comments: add include guard, fix macro evaluations, im…

c35f7f5

…prove error messages Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Complete review comment resolution

efc8c3a

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Add CodeQL symlink to .gitignore

960903c

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Update .gitignore

4c96ce6

ConorWilliams commented Jan 23, 2026

View reviewed changes

include/libfork/macros.hpp Outdated Show resolved Hide resolved

Copilot AI mentioned this pull request Jan 23, 2026

Remove doxygen-specific conditional from macros.hpp #51

Merged

Copilot AI and others added 13 commits January 23, 2026 23:03

Add Fibonacci serial benchmark with direct return

57552b4

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Complete: Add Fibonacci serial benchmark with direct return

54c6748

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Remove CodeQL artifact and update gitignore

0e1dd97

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Fix .gitignore formatting

be0e11c

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Remove doxygen-specific bits from macros.hpp

01b80c0

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

Complete removal of doxygen-specific bits

8afcfa5

Co-authored-by: ConorWilliams <47435400+ConorWilliams@users.noreply.github.com>

undo _codeql shenanigens

37c80db

reoder bench naming convention

7bdd9d9

shorten

2f2ffed

macros

231281b

prevent loop invariant lifting

4a2dc3d

spell

c3edd92

use do-not opt for basic fib as well

efdf0ec

ConorWilliams merged commit 214e6a9 into modules Jan 24, 2026
9 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[V4] benchmark skeleton #48

[V4] benchmark skeleton #48

Uh oh!

ConorWilliams commented Jan 21, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ConorWilliams commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

[V4] benchmark skeleton #48

[V4] benchmark skeleton #48

Uh oh!

Conversation

ConorWilliams commented Jan 21, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ConorWilliams commented Jan 23, 2026

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

Uh oh!

Copilot AI commented Jan 23, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

ConorWilliams commented Jan 21, 2026 •

edited

Loading