[V4] Scheduler split 4/4

[ConorWilliams]

Final transition to the new schedule API

Summary by CodeRabbit

Release Notes

• Refactor

  • Consolidated the public scheduling interface: schedule2 renamed to schedule for a unified entry point
  • Removed legacy context-based schedule overload to reduce API complexity
  • Simplified internal coroutine promise finalization and frame management

• Chores

  • Streamlined benchmark suite and configurations

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 153b361b-55d9-4e47-aa48-b23bf18d8135

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch v4-sched-split-4

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[coderabbitai]

Actionable comments posted: 1

🧹 Nitpick comments (1)

src/core/frame.cxx (1)

58-58: Stale comment references removed categories.

The comment mentions "Fork/Call/Just/Root" but the category enum now only contains call and fork. Consider updating to reflect the current state.

Suggested fix

-  category kind = static_cast<category>(0);     // Fork/Call/Just/Root
+  category kind = static_cast<category>(0);     // Fork/Call

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@src/core/frame.cxx` at line 58, The inline comment on the variable
declaration "category kind = static_cast<category>(0);" is stale (it lists
"Fork/Call/Just/Root") and should be updated to match the current enum values
(only call and fork) or removed; locate the declaration of category kind (and
the enum definition for category) and replace or simplify the comment to reflect
"call/fork" (or remove the comment entirely) so it accurately documents the
current enum options.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@src/core/promise.cxx`:
- Around line 177-252: Remove the unused helper function final_suspend_continue
from the file (it is dead code; its logic was inlined into final_suspend called
from final_awaitable::await_suspend) by deleting the entire template function
definition for final_suspend_continue and any forward declarations; ensure no
callers reference final_suspend_continue (search for symbol
final_suspend_continue and final_suspend_continue<) and run tests/compile to
confirm build success after removal.

---

Nitpick comments:
In `@src/core/frame.cxx`:
- Line 58: The inline comment on the variable declaration "category kind =
static_cast<category>(0);" is stale (it lists "Fork/Call/Just/Root") and should
be updated to match the current enum values (only call and fork) or removed;
locate the declaration of category kind (and the enum definition for category)
and replace or simplify the comment to reflect "call/fork" (or remove the
comment entirely) so it accurately documents the current enum options.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 766ab6de-165d-49aa-83fa-40bb61ac737b

📥 Commits

Reviewing files that changed from the base of the PR and between fd609eb and 180cb13.

📒 Files selected for processing (8)

• benchmark/CMakeLists.txt
• benchmark/src/libfork_benchmark/fib/lf_parts.cpp
• benchmark/src/libfork_benchmark/fib/libfork.cpp
• src/core/frame.cxx
• src/core/promise.cxx
• src/core/root.cxx
• src/core/schedule.cxx
• test/src/schedule.cpp

💤 Files with no reviewable changes (2)

• benchmark/CMakeLists.txt
• benchmark/src/libfork_benchmark/fib/lf_parts.cpp