Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@test/src/schedule.cpp`:
- Around line 46-52: Replace the preprocessor guard so the throwing test is only
compiled when exceptions are enabled: change the `#ifdef LF_COMPILER_EXCEPTIONS`
before the SECTION("throwing") block to `#if LF_COMPILER_EXCEPTIONS` (and keep
the matching `#endif`), ensuring the block around `schedule(scheduler,
throwing_function<Context>)`, `REQUIRE(recv.valid())`, and
`REQUIRE_THROWS_AS(std::move(recv).get(), std::runtime_error)` is omitted when
`LF_COMPILER_EXCEPTIONS` is defined as 0.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: e6026264-aec7-47d9-989a-de526353411b
📒 Files selected for processing (3)
src/core/promise.cxxsrc/core/schedule.cxxtest/src/schedule.cpp
💤 Files with no reviewable changes (1)
- src/core/schedule.cxx
b0ea04e to
e75e5b0
Compare
Summary by CodeRabbit
Bug Fixes
Tests