Skip to content

[V4] Schedule test exceptions#92

Merged
ConorWilliams merged 4 commits intomodulesfrom
v4-schedule-tests
Apr 6, 2026
Merged

[V4] Schedule test exceptions#92
ConorWilliams merged 4 commits intomodulesfrom
v4-schedule-tests

Conversation

@ConorWilliams
Copy link
Copy Markdown
Owner

@ConorWilliams ConorWilliams commented Apr 6, 2026

Summary by CodeRabbit

  • Bug Fixes

    • Improved exception handling during asynchronous fork and call operations to correctly propagate exceptions to parent coroutines.
  • Tests

    • Enhanced test coverage for scheduling functionality, including exception propagation validation and void task scheduling scenarios.

@ConorWilliams ConorWilliams changed the base branch from main to modules April 6, 2026 15:44
@coderabbitai
Copy link
Copy Markdown

coderabbitai bot commented Apr 6, 2026

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 5c592771-b4da-40d8-8871-b2ea7df6219d

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch v4-schedule-tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Copy Markdown

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@test/src/schedule.cpp`:
- Around line 46-52: Replace the preprocessor guard so the throwing test is only
compiled when exceptions are enabled: change the `#ifdef LF_COMPILER_EXCEPTIONS`
before the SECTION("throwing") block to `#if LF_COMPILER_EXCEPTIONS` (and keep
the matching `#endif`), ensuring the block around `schedule(scheduler,
throwing_function<Context>)`, `REQUIRE(recv.valid())`, and
`REQUIRE_THROWS_AS(std::move(recv).get(), std::runtime_error)` is omitted when
`LF_COMPILER_EXCEPTIONS` is defined as 0.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: e6026264-aec7-47d9-989a-de526353411b

📥 Commits

Reviewing files that changed from the base of the PR and between f6c07c5 and b0ea04e.

📒 Files selected for processing (3)
  • src/core/promise.cxx
  • src/core/schedule.cxx
  • test/src/schedule.cpp
💤 Files with no reviewable changes (1)
  • src/core/schedule.cxx

@ConorWilliams ConorWilliams merged commit c02b337 into modules Apr 6, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant