Merged
Conversation
2 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
|
All contributors have signed the CLA ✍️ ✅ |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
zilm13
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

PR Description
Vibe coded fix for the external address selection "bug" that was preventing teku from obtaining the ipv6 from discovery.
Fixed Issue(s)
Part of #10305
Note
Medium Risk
Changes external address auto-selection to update IPv4 and IPv6 ENR fields independently, which can affect how nodes advertise reachable endpoints. Main risk is incorrect ENR updates (e.g., flapping or missing one family) impacting peer connectivity in dual-stack environments.
Overview
Fixes dual-stack external address auto-discovery by selecting the best IPv4 and IPv6 external addresses independently instead of letting one IP family dominate and prevent the other from being published.
DefaultExternalAddressSelectornow runs separate vote-based selection for IPv4/IPv6 and updates the corresponding ENR field via a sharedmaybeUpdateAddresspath.Test utilities and coverage are extended to support IPv6 ENR fields:
SimpleIdentitySchemaInterpretercan now create/readudp6records and preserves the other family when updating an address, and newDefaultExternalAddressSelectorTestcases validate both families can be discovered and that IPv6 selection is independent of IPv4 vote volume.Written by Cursor Bugbot for commit 7db7228. This will update automatically on new commits. Configure here.