Downgrade routine peer-interaction logs from DEBUG to TRACE#215
Open
parthdagia05 wants to merge 2 commits intoConsensys:masterfrom
Open
Downgrade routine peer-interaction logs from DEBUG to TRACE#215parthdagia05 wants to merge 2 commits intoConsensys:masterfrom
parthdagia05 wants to merge 2 commits intoConsensys:masterfrom
Conversation
* add renovate * updates
|
All contributors have signed the CLA ✍️ ✅ |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
parthdagia05
force-pushed
the
fix/downgrade-verbose-debug-to-trace
branch
from
ad551b3 to
ea86775
Compare
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
There are 2 total unresolved issues (including 1 from previous review).
Reviewed by Cursor Bugbot for commit ea86775. Configure here.
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
Discovery v5 handlers log expected peer-interaction failures (bad packets, failed handshakes, policy-rejected peers, session timeouts) at DEBUG level, producing ~114 messages/minute on mainnet and making --logging=DEBUG output hard to read. Demote 16 such LOG.debug() calls across 9 files to LOG.trace(). The messages remain available at TRACE for protocol debugging; no LOG.warn/error/info calls are touched. Two additional debug calls in NodeSession#cancelAllRequests are intentionally left at DEBUG because they signal potential local-code issues (unexpected cleanup exception, possible race on requestIdStatuses) rather than routine peer behavior. Refs: besu-eth/besu#9691
parthdagia05
force-pushed
the
fix/downgrade-verbose-debug-to-trace
branch
from
ea86775 to
62fc1ea
Compare
joshuafernandes
force-pushed
the
master
branch
2 times, most recently
from
a8ea6c3 to
ccb2731
Compare
lucassaldanha
approved these changes
Apr 20, 2026
Member
lucassaldanha
left a comment
lucassaldanha
left a comment
There was a problem hiding this comment.
PR looks good. Only thing that needs to happen is a rebase due to the recent changes.
Contributor
|
@parthdagia05 Please rebase/merge upstream. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Demotes 16
LOG.debug()calls toLOG.trace()across 9 Discovery v5 handlerclasses. All 16 describe peer-caused events our node already handled correctly
(bad packets, failed handshakes, policy rejections, session timeouts) and were
producing ~114 messages/minute on mainnet, swamping
--logging=DEBUGoutput.Messages remain fully visible at
--logging=TRACE. NoLOG.warn/error/infocalls are touched.
Full rationale, measurements, and file-by-file breakdown: #<ISSUE_NUMBER>
Downstream: besu-eth/besu#9691
Deliberately left at DEBUG
Two
LOG.debugcalls inNodeSession#cancelAllRequeststhey signal possiblelocal-code issues (unexpected cleanup exception, race on
requestIdStatuses),not peer behavior.
Closed #214
Note
Low Risk
Log-level-only changes in discovery handlers; no functional behavior, state transitions, or error handling paths are modified.
Overview
Reduces noise in Discovery v5 by demoting routine peer-driven events from
DEBUGtoTRACEacross several packet/session handlers.This primarily affects logs for bad packets/decrypt failures, handshake validation failures, disallowed sources/destinations, and rejected
FINDNODEresults, keepingWARN/ERRORbehavior unchanged while making--logging=DEBUGoutput less chatty.Reviewed by Cursor Bugbot for commit 62fc1ea. Bugbot is set up for automated code reviews on this repo. Configure here.