Skip to content

Conversation

@NicolasMassart
Copy link
Member

@NicolasMassart NicolasMassart commented Mar 8, 2022

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Add missing quotes " in JSON code samples in the API page.

Issue fixed

Small fix, no ticket. Was reported on Slack.

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@NicolasMassart NicolasMassart requested a review from a team as a code owner March 8, 2022 08:19
@NicolasMassart NicolasMassart temporarily deployed to preview March 8, 2022 08:19 Inactive
@NicolasMassart NicolasMassart requested a review from ggarri March 8, 2022 08:19
@NicolasMassart NicolasMassart enabled auto-merge (squash) March 8, 2022 08:21
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@NicolasMassart NicolasMassart merged commit ff0c24c into Consensys:main Mar 8, 2022
@NicolasMassart NicolasMassart temporarily deployed to no-secret March 8, 2022 16:03 Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants