Skip to content

Conversation

@SatpalSandhu61
Copy link
Contributor

Pull request checklist

Use the following template to make sure your PR fits the GoQuorum documentation standard.

Before creating the PR

Make sure that:

Describe the change

Documentation describing how to set up GoQuorum to be used as a gas enabled network.
Requires associated code changes that are currently in a draft PR.

Impacted parts

For content changes:

  • Documentation content
  • Documentation page organization

For tool changes:

  • Build and QA tools (e.g., lint)
  • MkDocs templates
  • MkDocs configuration
  • Python dependencies
  • Node dependencies and JavaScript
  • GitHub integration

After creating your PR and tests have finished

Make sure that:

@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview July 8, 2022 14:42 Inactive
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview July 8, 2022 14:50 Inactive
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview July 8, 2022 14:56 Inactive
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview July 14, 2022 15:31 Inactive
@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview July 15, 2022 13:49 Inactive
@antonydenyer antonydenyer temporarily deployed to preview July 21, 2022 10:20 Inactive
@SatpalSandhu61 SatpalSandhu61 marked this pull request as ready for review July 21, 2022 10:54
@SatpalSandhu61 SatpalSandhu61 requested a review from a team as a code owner July 21, 2022 10:54
@rolandtyler rolandtyler temporarily deployed to preview July 21, 2022 15:38 Inactive
Copy link
Contributor

@rolandtyler rolandtyler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added some stylistic edits. LGTM

Copy link
Contributor

@alexandratran alexandratran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some suggestions. Feel free to Add suggestions to batch and commit them.

@SatpalSandhu61 SatpalSandhu61 temporarily deployed to preview July 22, 2022 09:27 Inactive
Committing some of the suggestions previously missed
@alexandratran alexandratran temporarily deployed to preview July 23, 2022 01:43 Inactive
@alexandratran alexandratran merged commit e30a926 into Consensys:main Jul 23, 2022
@alexandratran alexandratran temporarily deployed to no-secret July 23, 2022 18:31 Inactive
@SatpalSandhu61 SatpalSandhu61 deleted the enable-gas-price-v2 branch July 25, 2022 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants