linkchecker via npm package #87
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| shell: bash | ||
| run: | | ||
| npm install -g @umbrelladocs/linkspector | ||
| echo 'linkspector version: $(linkspector --version)' |
There was a problem hiding this comment.
Bug: Shell command substitution blocked by quoting.
The echo statement uses single quotes around the command substitution, which prevents the shell from executing the command. It will print the literal string "linkspector version: $(linkspector --version)" instead of showing the actual version. Should use double quotes or no quotes to allow command substitution.
| run: | | ||
| set -eo pipefail | ||
| echo "🔍 Checking for broken links..." | ||
| linkspector check -c ${{ inputs.CONFIG_FILE }} |
There was a problem hiding this comment.
Does this still allow optionally configuring the FAIL_LEVEL and FILTER_MODE for the linkspector action?
There was a problem hiding this comment.
I can put that in when I add in the build checks so it is similar to the last one - from memory that was for reviewdog but I'll dig into the levels to keep it compatible
There was a problem hiding this comment.
Oh, right it looks like it is for reviewdog (https://github.com/UmbrellaDocs/action-linkspector?tab=readme-ov-file#action-inputs). Without those settings, I wonder how this action will behave specifically for the filter mode (flagging errors for all changed files, added files only, etc.)
Note
Switches the docs link check to run linkspector via npm with Node setup and adds a Chrome sandbox workaround for Ubuntu 24.04.
docs-link-check/action.yml.nvmrcand set up Node viaactions/setup-node@v6.@umbrelladocs/linkspectorCLI (linkspector check -c ${{ inputs.CONFIG_FILE }}) instead of the action.README.mdwith a TODO to add lint checks.Written by Cursor Bugbot for commit b1e2bba. This will update automatically on new commits. Configure here.