Skip to content

Apply upstream changes to prevent crash when keystore-specific methods are called but external signer used #1028

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jpmsam merged 2 commits into from
Jul 6, 2020
Merged

Apply upstream changes to prevent crash when keystore-specific methods are called but external signer used #1028

jpmsam merged 2 commits into from
Jul 6, 2020

Conversation

@vsmk98
Copy link
Contributor

@vsmk98 vsmk98 commented Jul 6, 2020

Fixes the below issue:

Welcome to the Geth JavaScript console!

instance: Geth/v1.9.16-unstable-02cea233-20200626/darwin-amd64/go1.13.8
coinbase: 0x46b8ce2e9d3e7a0eb653d574afa506087997461e
at block: 9 (Sat Jun 27 2020 09:16:01 GMT+0800 (+08))
 datadir: 
 modules: admin:1.0 debug:1.0 eth:1.0 miner:1.0 net:1.0 personal:1.0 rpc:1.0 txpool:1.0 web3:1.0

> personal.importRawKey("<<_keyValue_>>", "")
Error: method handler crashed
	at web3.js:6347:37(47)
	at web3.js:5081:62(37)
	at <eval>:1:22(5)

> personal.newAccount()
Passphrase:
Repeat passphrase:
GoError: Error: method handler crashed at web3.js:6347:37(47)
	at native
	at <eval>:1:1(2)

Fixes #21266
Picked from geth PR #21279

holiman and others added 2 commits July 6, 2020 09:17
@holiman @vsmk98
ethapi: don't crash when keystore-specific methods are called but ext…
f88777a 
…ernal signer used (#21279)

* console: prevent importRawKey from getting into CLI history

* internal/ethapi: error on keystore-methods when no keystore is present

(cherry picked from commit 04c4e50)
@jpmsam
Merge branch 'master' into fix/clef-keystore-crash
dc49ad7
@jpmsam jpmsam merged commit 54cb958 into master Jul 6, 2020
@antonydenyer antonydenyer deleted the fix/clef-keystore-crash branch January 20, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jpmsam jpmsam jpmsam approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Clef - method handler crashed error for new account and import raw key apis

4 participants

@vsmk98 @jpmsam @holiman