Skip to content

Conversation

@zzy96
Copy link
Contributor

@zzy96 zzy96 commented Feb 20, 2020

Fix #920

There are issues currently with import & export chain for Quorum. This PR fixes these issues

For Quorum Chain Export

e.g.

geth export --datadir qdata/dd1 export.bin

For Quorum Chain Import

Keep Tessera running and provide PRIVATE_CONFIG environment variable if there are private transaction in the imported chain data. Tessera must not lose its private transaction data. The node must be initiated by proper genesis file already before calling geth import.

e.g.

PRIVATE_CONFIG=qdata/c1/tm.ipc geth import --datadir qdata/dd1 export.bin

@vsmk98 vsmk98 requested a review from trung February 21, 2020 00:19
Copy link
Contributor

@trung trung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you can retrieve chain config from the database. Trace the usage from:
https://github.com/jpmorganchase/quorum/blob/439f52942a15d4b9f8ea930a7a0c19399b4a226b/core/rawdb/accessors_metadata.go#L47-L72

This way you don't need to introduce new param to the existing command.

trung
trung previously approved these changes Feb 27, 2020
Copy link
Contributor

@trung trung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

fixanoid
fixanoid previously approved these changes Feb 27, 2020
@zzy96 zzy96 dismissed stale reviews from fixanoid and trung via e7fd03c March 1, 2020 01:39
@jpmsam jpmsam merged commit 9111ffd into master Mar 2, 2020
@zzy96 zzy96 deleted the import-export-chain branch March 2, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

geth restore network with import command failed

6 participants