Skip to content

Configuration of Implementation Model#137

Merged
Samweli merged 52 commits intoConservationInternational:mainfrom
gkahiu:step_two_imp_model
Jul 12, 2023
Merged

Configuration of Implementation Model#137
Samweli merged 52 commits intoConservationInternational:mainfrom
gkahiu:step_two_imp_model

Conversation

@gkahiu
Copy link
Copy Markdown
Collaborator

@gkahiu gkahiu commented Jun 21, 2023

Fixes #76
Mapping of NCS pathways to implementation models in step two of setting up a scenario.

@Samweli Samweli closed this Jun 23, 2023
@Samweli Samweli reopened this Jun 23, 2023
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Jun 23, 2023

badge

Plugin zip package for the changes in this PR has been successfully built!.

Download the plugin zip file here https://github.com/kartoza/cplus-plugin/suites/14234184721/artifacts/799192264

@gkahiu
Copy link
Copy Markdown
Collaborator Author

gkahiu commented Jun 24, 2023

@Samweli please see the near-final changes to step two, only thing remaining is defining the file names for the NCS pathway files here, could not update as am unable to download the ZIP files, will follow-up separately. Also, this will also be dependent on the settings work, specifically on the base data directory so that we can use this to build the absolute path for the NCS pathway layers using this snippet.

@Samweli
Copy link
Copy Markdown
Collaborator

Samweli commented Jun 28, 2023

@Samweli please see the near-final changes to step two, only thing remaining is defining the file names for the NCS pathway

Thanks @gkahiu, can you fix the PR conflicts then I can post my review and we can move forward from there, thanks.

@gkahiu
Copy link
Copy Markdown
Collaborator Author

gkahiu commented Jul 7, 2023

@Samweli see the updated PR which resolves the comments that you raised.

On the use of sqlite, I debated on this as well. On one hand, its use is definitely relevant if we are storing multiple scenarios with each scenario being linked to the respective implementation models, which are then subsequently linked to the respective NCS pathways. However, since we, at least for the current implementation, are only dealing with one scenario at any one time then the level of effort vs. the comparative advantage would be a bit skewed. I also considered JSON as another data source/store and maybe we might need to implement some aspects of it in the next epic.

Other considerations included:

  • Consistency in using one store for the application data. Hence, the settings approach seemed more appropriate;
  • Ease of use in making direct changes - while the dbmanager could have been used for editing the NCS pathway properties, the current implementation of settings is much more easier since any text editor can be used to make changes.

That said, the implementation is flexible and can always revert to the original idea of adopting sqlite as the requirements evolve.

self._update_controls()
self._edit_mode = True

help_icon = QgsApplication.instance().getThemeIcon("mActionHelpContents.svg")
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gkahiu thanks, the line above should now change to fetch the icon from the plugin icon directory right?

@gkahiu
Copy link
Copy Markdown
Collaborator Author

gkahiu commented Jul 11, 2023

Hi @Samweli, thanks. The icon source is now fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

User Story 4: Step 2: Implementation Models Tab

2 participants