Skip to content

Remove quizzes is_last_question #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Remove quizzes is_last_question #132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion library/src/main/java/io/constructor/data/model/quiz/QuizQuestionResponse.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@ data class QuizQuestionResponse(
@Json(name="next_question") val nextQuestion: QuizQuestion?,
@Json(name="quiz_version_id") val quizVersionId: String?,
@Json(name="quiz_session_id") val quizSessionId: String?,
@Json(name="is_last_question") val isLastQuestion: Boolean?,
@Json(name="quiz_id") val quizId: String,
var rawData: String?
) : Serializable
6 changes: 0 additions & 6 deletions library/src/test/java/io/constructor/core/ConstructorIoIntegrationQuizTest.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -62,7 +62,6 @@ class ConstructorIoIntegrationQuizTest {
assertNotNull(quizResult?.quizId)
assertNotNull(quizResult?.quizVersionId)
assertNotNull(quizResult?.quizSessionId)
assertEquals(quizResult?.isLastQuestion, false)
assertEquals(quizResult?.nextQuestion?.id, 1)
assertEquals(quizResult?.nextQuestion?.title, "This is a test quiz.")
assertEquals(quizResult?.nextQuestion?.images?.primaryUrl, "/test-asset")
Expand Down Expand Up @@ -108,7 +107,6 @@ class ConstructorIoIntegrationQuizTest {
assertNotNull(quizResult?.quizId)
assertNotNull(quizResult?.quizVersionId)
assertNotNull(quizResult?.quizSessionId)
assertEquals(quizResult?.isLastQuestion, false)
assertEquals(quizResult?.nextQuestion?.id, 2)
assertEquals(quizResult?.nextQuestion?.title, "This is a multiple select question")
assertEquals(quizResult?.nextQuestion?.images?.primaryUrl, "/test-asset")
Expand Down Expand Up @@ -142,7 +140,6 @@ class ConstructorIoIntegrationQuizTest {
assertNotNull(quizResult?.quizId)
assertNotNull(quizResult?.quizVersionId)
assertNotNull(quizResult?.quizSessionId)
assertEquals(quizResult?.isLastQuestion, false)
assertEquals(quizResult?.nextQuestion?.id, 3)
assertEquals(quizResult?.nextQuestion?.title, "Test Cover")
assertEquals(quizResult?.nextQuestion?.images?.primaryUrl, "/test-asset")
Expand Down Expand Up @@ -170,7 +167,6 @@ class ConstructorIoIntegrationQuizTest {
assertNotNull(quizResult?.quizId)
assertNotNull(quizResult?.quizVersionId)
assertNotNull(quizResult?.quizSessionId)
assertEquals(quizResult?.isLastQuestion, true)
assertEquals(quizResult?.nextQuestion?.id, 4)
assertEquals(quizResult?.nextQuestion?.title, "Test Open Text")
assertEquals(quizResult?.nextQuestion?.images?.primaryUrl, "/test-asset")
Expand Down Expand Up @@ -200,7 +196,6 @@ class ConstructorIoIntegrationQuizTest {
assertNotNull(quizResult?.quizId)
assertNotNull(quizResult?.quizVersionId)
assertNotNull(quizResult?.quizSessionId)
assertEquals(quizResult?.isLastQuestion, true)
assertEquals(quizResult?.nextQuestion, null)

Thread.sleep(timeBetweenTests)
Expand Down Expand Up @@ -267,7 +262,6 @@ class ConstructorIoIntegrationQuizTest {
assertNotNull(quizResult?.quizId)
assertNotNull(quizResult?.quizVersionId)
assertNotNull(quizResult?.quizSessionId)
assertEquals(quizResult?.isLastQuestion, true)
assertEquals(quizResult?.nextQuestion?.id, 4)
assertEquals(quizResult?.nextQuestion?.title, "Test Open Text")
assertEquals(quizResult?.nextQuestion?.images?.primaryUrl, "/test-asset")
Expand Down
3 changes: 1 addition & 2 deletions library/src/test/resources/quiz_next_response.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,5 @@
},
"quiz_version_id": "11db5ac7-67e1-4000-9000-414d8425cab3",
"quiz_session_id": "31f6bdae-6f1d-482f-b37f-f7a9e346973a",
"quiz_id": "test-quiz",
"is_last_question": false
"quiz_id": "test-quiz"
}