[CH12120] Change Method to POST #54
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crgee1
commented
Dec 3, 2020
| val path = "/v2/behavioral_action/browse_result_click?filter_name=group_id&filter_value=Movies&customer_id=TIT-REP-1997&result_position_on_page=4&autocomplete_section=Products&key=copper-key&i=wacko-the-guid&ui=player-three&s=67&c=cioand-2.3.0&_dt="; | ||
| assert(request.path.startsWith(path)) | ||
| val request = mockServer.takeRequest(10, TimeUnit.SECONDS) | ||
| assertEquals(null, request) |
Contributor
Author
There was a problem hiding this comment.
throttleBody throttles the request reader and response writer, so it might make sense for the mockServer.takeRequest(10, TimeUnit.SECONDS) to return null
crgee1
commented
Dec 3, 2020
| val path = "/v2/behavioral_action/browse_result_load?filter_name=group_id&filter_value=Movies&num_results=10&action=browse-results&key=copper-key&i=wacko-the-guid&ui=player-three&s=67&c=cioand-2.3.0&_dt="; | ||
| assert(request.path.startsWith(path)) | ||
| val request = mockServer.takeRequest(10, TimeUnit.SECONDS) | ||
| assertEquals(null, request) |
Contributor
Author
There was a problem hiding this comment.
throttleBody throttles the request reader and response writer, so it might make sense for the mockServer.takeRequest(10, TimeUnit.SECONDS) to return null
rubikzube
suggested changes
Dec 10, 2020
library/src/main/java/io/constructor/data/model/browse/BrowseRequestBody.kt
Outdated
Show resolved
Hide resolved
| @Query("customer_id") customerId: String, | ||
| @Query("result_position_on_page") resultPositionOnPage: Int, | ||
| @POST(ApiPaths.URL_BROWSE_RESULT_CLICK_EVENT) | ||
| fun trackBrowseResultClick(@Body browseRequestBody: BrowseRequestBody, |
rubikzube
suggested changes
Dec 11, 2020
Contributor
rubikzube
left a comment
rubikzube
left a comment
There was a problem hiding this comment.
For browse result click and load we also need to pass query params set in the URL in the request body (a.k.a most of the params set in the RequestInterceptor)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.