Skip to content

Update search events group Id documentation #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 2, 2025
Merged

Update search events group Id documentation #229

merged 2 commits into from
Jan 2, 2025

Conversation

@mocca102
Copy link
Contributor

@mocca102 mocca102 commented Oct 13, 2024

Before

  • group: Item group (if present)

After

  • group: The group to search within if a user elected to search in a group, i.e. "Pumpkin in Canned Goods" (if present)

Changed in

  • trackAutocompleteSelect
  • trackSearchSubmit

@mocca102 mocca102 requested a review from a team October 29, 2024 23:08
jjl014
jjl014 approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jjl014 jjl014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@stanlp1 stanlp1 merged commit ea2d3d0 into master Jan 2, 2025
2 checks passed
@stanlp1 stanlp1 deleted the noci-update-search-events-group-id-documentation branch January 2, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jjl014 jjl014 jjl014 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@mocca102 @jjl014 @stanlp1