Skip to content

Conversation

@deomsj
Copy link
Contributor

@deomsj deomsj commented Jan 9, 2023

✅ make css selectors less specific so they can be easily overridden
✅ add position absolute to dropdown
✅ hide the dropdown when there are no results to display
✅ ability to pass custom class name to container element
✅ ability to opt out of default styles
✅ ability to extend default styles
✅ update readme image to new custom styles story w/ gif

@deomsj deomsj requested review from a team January 9, 2023 12:26
@linear
Copy link

linear bot commented Jan 9, 2023

PSL-1468 CSS: Improvements from Enes feedback

Business Outcome:

As Enes I want easy way for customers to override default styles and and pass their own styles so that they have better developer experience

Definition of done:

  • ✅ make css selectors less specific so they can be easily overridden
  • ✅ add position absolute to dropdown
  • ✅ hide the dropdown when there are no results to display
  • ✅ ability to pass custom class name to container element
  • ✅ ability to opt out of default styles
  • ✅ ability to extend default styles
  • 🤷 BONUS: click outside closes the dropdown (specifically with clicking in browser dev tools?)

Additional Notes:

@deomsj deomsj added the release:minor for version and release github action label Jan 9, 2023
Copy link
Contributor

@gardensgreen gardensgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks great aside for small grammatical error I pointed out within comment below .

Nice work! :D

src/constants.ts Outdated

// from .storybook/custom-styles-story.css
export const customStylesDescription = `
This library provides some default styles. These default styles can provide as a foundation to build on top of or just as a reference for you to replace completely. All default styles in this library are scoped within the \`.cio-autocomplete\` css selector.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This library provides some default styles. These default styles can provide as a foundation to build on top of or just as a reference for you to replace completely. All default styles in this library are scoped within the `.cio-autocomplete` css selector.

->

This library provides some default styles. These default styles can be used as a foundation to build on top of or just as a reference for you to replace completely. All default styles in this library are scoped within the `.cio-autocomplete` css selector.

@deomsj deomsj requested a review from gardensgreen January 9, 2023 16:53
Copy link
Contributor

@gardensgreen gardensgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@deomsj deomsj merged commit dd4d996 into main Jan 9, 2023
@deomsj deomsj deleted the psl-1468-css-improvements-from-enes-feedback branch January 9, 2023 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release:minor for version and release github action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants