-
Notifications
You must be signed in to change notification settings - Fork 3
Psl 1468 css improvements from enes feedback #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
PSL-1468 CSS: Improvements from Enes feedback
Business Outcome: As Enes I want easy way for customers to override default styles and and pass their own styles so that they have better developer experience Definition of done:
Additional Notes:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks great aside for small grammatical error I pointed out within comment below .
Nice work! :D
src/constants.ts
Outdated
|
|
||
| // from .storybook/custom-styles-story.css | ||
| export const customStylesDescription = ` | ||
| This library provides some default styles. These default styles can provide as a foundation to build on top of or just as a reference for you to replace completely. All default styles in this library are scoped within the \`.cio-autocomplete\` css selector. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This library provides some default styles. These default styles can provide as a foundation to build on top of or just as a reference for you to replace completely. All default styles in this library are scoped within the `.cio-autocomplete` css selector.
->
This library provides some default styles. These default styles can be used as a foundation to build on top of or just as a reference for you to replace completely. All default styles in this library are scoped within the `.cio-autocomplete` css selector.
gardensgreen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
![]()
✅ make css selectors less specific so they can be easily overridden
✅ add position absolute to dropdown
✅ hide the dropdown when there are no results to display
✅ ability to pass custom class name to container element
✅ ability to opt out of default styles
✅ ability to extend default styles
✅ update readme image to new custom styles story w/ gif